[Bugs] [Bug 1129939] NetBSD port

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1129939



--- Comment #212 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/9071 committed in master by Raghavendra Bhat
(raghavendra at redhat.com) 
------
commit e398f99d9ac7ca5c83004b814a4e8561916187f0
Author: Emmanuel Dreyfus <manu at netbsd.org>
Date:   Wed Dec 17 10:41:05 2014 +0100

    telldir()/seekdir() portability fixes

    POSIX says that an offset obtained from telldir() can only be used
    on the same DIR *. Linux is abls to reuse the offset accross
    closedir()/opendir() for a given directory, but this is not portable
    and such a behavior should be fixed.

    An incomplete fix for the posix xlator was merged in
    http://review.gluster.com/8926
    This change set completes it.

    - Perform the same fix index xlator.
    - Use appropriate casts and variable types so that 32 bit signed
      offsets obtained by telldir() do not get clobbered when copied into
      64 bit signed types.
    - modify glfs-heal.c and afr-self-heald.c so that they do not use
      anonymous fd, since this will cause closedir()/opendir() between
      each syncop_readdir(). On failure we fallback to anonymous fs
      only for Linux so that we can cope with updated client vs not
      updated brick.
    - Avoid sending an EINVAL when the client request for the EOF offset.
      Here we fix an error in previous fix for posix xlator: since we
      fill each directory entry with the offset of the next entry, we
      must consider as EOF the offset of the last entry, and not the
      value of telldir() after we read it.
    - Add checks in regression tests that we do not hit cases where
      offsets fed to seekdir() are wrong. Introduce log_newer() shell
      function to check for messages produced by the current script.

    This fix gather changes from http://review.gluster.org/9047
    and http://review.gluster.org/8936 making them obsolete.

    BUG: 1129939
    Change-Id: I59fb7f06a872c4f98987105792d648141c258c6a
    Signed-off-by: Emmanuel Dreyfus <manu at netbsd.org>
    Reviewed-on: http://review.gluster.org/9071
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Raghavendra Bhat <raghavendra at redhat.com>
    Tested-by: Raghavendra Bhat <raghavendra at redhat.com>

-- 
You are receiving this mail because:
You are the assignee for the bug.