[Bugs] [Bug 1173513] New: mount.glusterfs fails to check return of mount command.

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1173513

            Bug ID: 1173513
           Summary: mount.glusterfs fails to check return of mount
                    command.
           Product: GlusterFS
           Version: 3.6.1
         Component: fuse
          Keywords: EasyFix, Patch, Triaged
          Severity: medium
          Priority: medium
          Assignee: bugs at gluster.org
          Reporter: ndevos at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com,
                    hchiramm at redhat.com, ndevos at redhat.com,
                    sbonazzo at redhat.com
        Depends On: 1128165
            Blocks: 1163723 (glusterfs-3.6.2)



+++ This bug was initially created as a clone of Bug #1128165 +++

Description of problem:

Current version of mount.glusterfs does not check the return of mount command
and it causes failure in fetching proper return of the same.



Version-Release number of selected component (if applicable):

GlusterFS-3.6

How reproducible:

[root at node ~]# mount -t glusterfs 10.19.96.13:test_vol2 /mnt/h

[1]

[root at node ~]# mount|grep mnt
[root at node ~]# tail -n 10 /var/log/glusterfs/mnt-h.log 
[2014-08-08 09:54:28.054719] I [glusterfsd-mgmt.c:1817:mgmt_rpc_notify]
0-glusterfsd-mgmt: Exhausted all volfile servers
[2014-08-08 09:54:28.054920] W [glusterfsd.c:1182:cleanup_and_exit] (--> 0-:
received signum (1), shutting down
[2014-08-08 09:54:28.054955] I [fuse-bridge.c:5561:fini] 0-fuse: Unmounting
'/mnt/h'.
[2014-08-08 13:08:56.651005] I [MSGID: 100030] [glusterfsd.c:1998:main]
0-/usr/sbin/glusterfs: Started running /usr/sbin/glusterfs version 3.6.0.22
(args: /usr/sbin/glusterfs --volfile-server=10.19.96.13 --volfile-id=test_vol2
/mnt/h)
[2014-08-08 13:08:56.769335] E [socket.c:2169:socket_connect_finish]
0-glusterfs: connection to 10.19.96.13:24007 failed (Connection refused)
[2014-08-08 13:08:56.769409] E [glusterfsd-mgmt.c:1811:mgmt_rpc_notify]
0-glusterfsd-mgmt: failed to connect with remote-host: 10.19.96.13 (Transport
endpoint is not connected)
[2014-08-08 13:08:56.769426] I [glusterfsd-mgmt.c:1817:mgmt_rpc_notify]
0-glusterfsd-mgmt: Exhausted all volfile servers
[2014-08-08 13:08:56.769622] W [glusterfsd.c:1182:cleanup_and_exit] (--> 0-:
received signum (1), shutting down
[2014-08-08 13:08:56.769656] I [fuse-bridge.c:5561:fini] 0-fuse: Unmounting
'/mnt/h'.
[2014-08-08 13:08:56.779998] W [glusterfsd.c:1182:cleanup_and_exit] (--> 0-:
received signum (15), shutting down
[root at node ~]# 

Even-though mount failed, there is no way to identify whether it was a
successful mount or not.

[1] No output returned to the user.

With the patch :

[root at node ~]# mount -t glusterfs 10.19.96.13:test_vol2 /mnt/h
Mount failed. Please check the log file for more details.
[root at node ~]# 


Actual results:

No error returned for the user.

Expected results:

If failed, it should be messaged to the user.


Additional info:

--- Additional comment from Sandro Bonazzola on 2014-12-12 11:06:35 CET ---

Still reproducible with 

# rpm -qa |grep gluster |sort
glusterfs-3.6.1-1.el7.x86_64
glusterfs-api-3.6.1-1.el7.x86_64
glusterfs-cli-3.6.1-1.el7.x86_64
glusterfs-fuse-3.6.1-1.el7.x86_64
glusterfs-libs-3.6.1-1.el7.x86_64
glusterfs-rdma-3.6.1-1.el7.x86_64
glusterfs-server-3.6.1-1.el7.x86_64

--- Additional comment from Niels de Vos on 2014-12-12 11:41:21 CET ---

http://review.gluster.org/8438 has been committed in the master branch, and
should get backported to release-3.6 and 3.5. I'll clone this bug so that we
can post the patches.


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1128165
[Bug 1128165] mount.glusterfs fails to check return of mount command.
https://bugzilla.redhat.com/show_bug.cgi?id=1163723
[Bug 1163723] GlusterFS 3.6.2 tracker
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.