[Bugs] [Bug 1170959] New: EC_MAX_NODES is defined incorrectly

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1170959

            Bug ID: 1170959
           Summary: EC_MAX_NODES is defined incorrectly
           Product: GlusterFS
           Version: 3.6.1
         Component: disperse
          Keywords: Triaged
          Assignee: bugs at gluster.org
          Reporter: xhernandez at datalab.es
                CC: bugs at gluster.org, gluster-bugs at redhat.com,
                    wf_cs at yahoo.com
        Depends On: 1167419



+++ This bug was initially created as a clone of Bug #1167419 +++

Description of problem:

The macro is defined in ec.c file as the following statement.

#define EC_MAX_NODES    (EC_MAX_FRAGMENTS + ((EC_MAX_FRAGMENTS - 1) / 2))

However the number of the redundancy should be less than the number of
fragment, instead of half of it.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2014-11-25 09:57:26 CET ---

REVIEW: http://review.gluster.org/9193 (ec: Fix incorrect value of
EC_MAX_NODES) posted (#1) for review on master by Xavier Hernandez
(xhernandez at datalab.es)

--- Additional comment from Anand Avati on 2014-12-04 20:35:23 CET ---

COMMIT: http://review.gluster.org/9193 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit ca2a3949715fb25862d1e34f9e65283287faa842
Author: Xavier Hernandez <xhernandez at datalab.es>
Date:   Tue Nov 25 09:54:29 2014 +0100

    ec: Fix incorrect value of EC_MAX_NODES

    EC_MAX_NODES was incorrectly calculated. Now the value if computed
    as the minimum between the theoretical maximum and the limit imposed
    by the Galois Field.

    Change-Id: I75a8345147f344f051923d66be2c10d405370c7b
    BUG: 1167419
    Signed-off-by: Xavier Hernandez <xhernandez at datalab.es>
    Reviewed-on: http://review.gluster.org/9193
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Dan Lambright <dlambrig at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1167419
[Bug 1167419] EC_MAX_NODES is defined incorrectly
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.