[Bugs] [Bug 1170830] New: io-stats may crash the brick when loc->path is NULL in some fops

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1170830

            Bug ID: 1170830
           Summary: io-stats may crash the brick when loc->path is NULL in
                    some fops
           Product: Red Hat Storage
           Version: 3.0
         Component: glusterfs-server
          Severity: high
          Assignee: rhs-bugs at redhat.com
          Reporter: fharshav at redhat.com
        QA Contact: storage-qa-internal at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com,
                    nlevinki at redhat.com, pkarampu at redhat.com,
                    vbellur at redhat.com
        Depends On: 1159221
             Group: redhat



+++ This bug was initially created as a clone of Bug #1159221 +++

Description of problem:
Cases where loc->path is NULL, the current code in create/open/mkdir
would copy the same blindly and as a result coredump. One such case is when
resolve_loc_touchup fails to get inode_path due to loops in the inode table.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2014-10-31 05:07:57 EDT ---

REVIEW: http://review.gluster.org/9029 (xlator/io-stat: Check and copy
loc->path) posted (#1) for review on master by Pranith Kumar Karampuri
(pkarampu at redhat.com)

--- Additional comment from Anand Avati on 2014-11-06 00:30:34 EST ---

COMMIT: http://review.gluster.org/9029 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit 08109ed5a7e09ec14ecb3640cfcaf9b32d83499b
Author: Shyam <srangana at redhat.com>
Date:   Fri Oct 24 15:44:22 2014 -0400

    xlator/io-stat: Check and copy loc->path

    Cases where loc->path is NULL, the current code in create/open/mkdir
    would copy the same blindly and as a result coredump.

    This is a preventive fix for the coredump. The reason for loc->path
    to be NULL in certain cases is yet to be determined.

    One such case is when resolve_loc_touchup fails to get inode_path due
    to loops in the inode table.

    Change-Id: Ic2ddf2cc9f2acaf9b939afc11afd193b4402ee7c
    BUG: 1159221
    Signed-off-by: Shyam <srangana at redhat.com>
    Reviewed-on: http://review.gluster.org/9029
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Vijay Bellur <vbellur at redhat.com>


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1159221
[Bug 1159221] io-stats may crash the brick when loc->path is NULL in some
fops
-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=Q5v7oJBkxU&a=cc_unsubscribe