[Bugs] [Bug 1161588] ls -alR can not heal the disperse volume

[bugzilla at redhat.com]

https://bugzilla.redhat.com/show_bug.cgi?id=1161588



--- Comment #3 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/9072 committed in master by Vijay Bellur
(vbellur at redhat.com) 
------
commit bc91dd4de39ffd481a52b837f322f6782c14e9f1
Author: Xavier Hernandez <xhernandez at datalab.es>
Date:   Fri Nov 7 12:12:19 2014 +0100

    ec: Fix self-healing issues.

    Three problems have been detected:

    1. Self healing is executed in background, allowing the fop that
       detected the problem to continue without blocks nor delays.

       While this is quite interesting to avoid unnecessary delays,
       it can cause spurious failures of self-heal because it may
       try to recover a file inside a directory that a previous
       self-heal has not recovered yet, causing the file self-heal
       to fail.

    2. When a partial self-heal is being executed on a directory,
       if a full self-heal is attempted, it won't be executed
       because another self-heal is already in process, so the
       directory won't be fully repaired.

    3. Information contained in loc's of some fop's is not enough
       to do a complete self-heal.

    To solve these problems, I've made some changes:

    * Improved ec_loc_from_loc() to add all available information
      to a loc.

    * Before healing an entry, it's parent is checked and partially
      healed if necessary to avoid failures.

    * All heal requests received for the same inode while another
      self-heal is being processed are queued. When the first heal
      completes, all pending requests are answered using the results
      of the first heal (without full execution), unless the first
      heal was a partial heal. In this case all partial heals are
      answered, and the first full heal is processed normally.

    * An special virtual xattr (not physically stored on bricks)
      named 'trusted.ec.heal' has been created to allow synchronous
      self-heal of files.

      Now, the recommended way to heal an entire volume is this:

        find <mount> -d -exec getfattr -h -n trusted.ec.heal {} \;

    Some minor changes:

    * ec_loc_prepare() has been renamed to ec_loc_update().

    * All loc management functions return 0 on success and -1 on
      error.

    * Do not delay fop unlocks if heal is needed.

    * Added basic ec xattrs initially on create, mkdir and mknod
      fops.

    * Some coding style changes

    Change-Id: I2a5fd9c57349a153710880d6ac4b1fa0c1475985
    BUG: 1161588
    Signed-off-by: Xavier Hernandez <xhernandez at datalab.es>
    Reviewed-on: http://review.gluster.org/9072
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Dan Lambright <dlambrig at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ZElxv5r11A&a=cc_unsubscribe