[Bugs] [Bug 1170548] New: [USS] : don't display the snapshots which are not activated

Thu Dec 4 10:09:27 UTC 2014

https://bugzilla.redhat.com/show_bug.cgi?id=1170548

            Bug ID: 1170548
           Summary: [USS] : don't display the snapshots which are not
                    activated
           Product: GlusterFS
           Version: 3.6.1
         Component: snapshot
          Keywords: Triaged
          Severity: medium
          Priority: medium
          Assignee: bugs at gluster.org
          Reporter: rabhat at redhat.com
                CC: bugs at gluster.org, gluster-bugs at redhat.com,
                    spandit at redhat.com, vbellur at redhat.com
        Depends On: 1155042

+++ This bug was initially created as a clone of Bug #1155042 +++

Description of problem:
It is better not to display the snapshots if they are not activated.
Displaying the snapshots might confuse the user as he might this that
the displayed snapshot might be in usable state.

Version-Release number of selected component (if applicable):

How reproducible:
1/1

Steps to Reproduce:
1. create a volume
2. mount the volume
3. enable uss
3. go to <mount-path>/.snaps
4. create a snapshot (snap1)
5. check if snapshot snap1 is present
6. deactivate the snapshot snap1
and you can see the snap1 is still present

Actual results:
deactivated snapshot is still being displayed

Expected results:
don't display the deactivated snapshots.

Additional info:

--- Additional comment from Anand Avati on 2014-10-21 06:09:44 EDT ---

REVIEW: http://review.gluster.org/8958 (USS : fetch only the activated
snapshots) posted (#1) for review on master by Sachin Pandit
(spandit at redhat.com)

--- Additional comment from Anand Avati on 2014-11-07 01:09:10 EST ---

REVIEW: http://review.gluster.org/8958 (USS : Display only the activated
snapshots) posted (#2) for review on master by Sachin Pandit
(spandit at redhat.com)

--- Additional comment from Anand Avati on 2014-11-07 01:13:02 EST ---

REVIEW: http://review.gluster.org/8958 (USS : Display only the activated
snapshots) posted (#3) for review on master by Sachin Pandit
(spandit at redhat.com)

--- Additional comment from Anand Avati on 2014-11-07 05:35:48 EST ---

REVIEW: http://review.gluster.org/8958 (USS : Display only the activated
snapshots) posted (#4) for review on master by Sachin Pandit
(spandit at redhat.com)

--- Additional comment from Anand Avati on 2014-11-10 01:03:47 EST ---

REVIEW: http://review.gluster.org/8958 (USS : Display only the activated
snapshots) posted (#5) for review on master by Sachin Pandit
(spandit at redhat.com)

--- Additional comment from Anand Avati on 2014-11-10 03:39:58 EST ---

REVIEW: http://review.gluster.org/8958 (USS : Display only the activated
snapshots) posted (#6) for review on master by Sachin Pandit
(spandit at redhat.com)

--- Additional comment from Anand Avati on 2014-11-11 00:35:38 EST ---

REVIEW: http://review.gluster.org/8958 (USS : Display only the activated
snapshots) posted (#7) for review on master by Sachin Pandit
(spandit at redhat.com)

--- Additional comment from Anand Avati on 2014-11-12 06:20:14 EST ---

COMMIT: http://review.gluster.org/8958 committed in master by Krishnan
Parthasarathi (kparthas at redhat.com) 
------
commit 70b0c7b725408fc82969e15dcf67cd352b0fb68b
Author: Sachin Pandit <spandit at redhat.com>
Date:   Tue Oct 21 07:57:22 2014 +0530

    USS : Display only the activated snapshots

    Instead of displaying all the snapshots in the uss world,
    it is better if we display only the activated snapshots.

    Change-Id: I70d3ec212b62ec15956ae3e826bc4201d8dedd17
    BUG: 1155042
    Signed-off-by: Sachin Pandit <spandit at redhat.com>
    Reviewed-on: http://review.gluster.org/8958
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Avra Sengupta <asengupt at redhat.com>
    Reviewed-by: Rajesh Joseph <rjoseph at redhat.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas at redhat.com>
    Tested-by: Krishnan Parthasarathi <kparthas at redhat.com>

--- Additional comment from Anand Avati on 2014-11-13 00:38:33 EST ---

REVIEW: http://review.gluster.org/9113 (test/uss : activate the snapshot after
creating.) posted (#1) for review on master by Sachin Pandit
(spandit at redhat.com)

--- Additional comment from Anand Avati on 2014-11-13 00:38:58 EST ---

REVIEW: http://review.gluster.org/9113 (test/uss : activate the snapshot after
creating.) posted (#2) for review on master by Sachin Pandit
(spandit at redhat.com)

--- Additional comment from Anand Avati on 2014-11-13 00:47:29 EST ---

REVIEW: http://review.gluster.org/9113 (test/uss : activate the snapshot after
creating.) posted (#3) for review on master by Sachin Pandit
(spandit at redhat.com)

--- Additional comment from Anand Avati on 2014-11-13 04:19:10 EST ---

COMMIT: http://review.gluster.org/9113 committed in master by Kaushal M
(kaushal at redhat.com) 
------
commit 75474f148daada475c235d0acaf345acad4ba9f3
Author: Sachin Pandit <spandit at redhat.com>
Date:   Thu Nov 13 03:57:57 2014 +0530

    test/uss : activate the snapshot after creating.

    Till now we were activating the snapshot along with the snapshot create.
    But one of the recent patches has changed that behavior. Now we have
    to explicitly issue activate-on-create using snapshot config if we
    want snapshot to be activated during snapshot create.

    Till patch fixes the regression failure which is seen lately.

    Change-Id: Ic53b16e22569e521bd70dd3bfa7154a0424151ce
    BUG: 1155042
    Signed-off-by: Sachin Pandit <spandit at redhat.com>
    Reviewed-on: http://review.gluster.org/9113
    Reviewed-by: Rajesh Joseph <rjoseph at redhat.com>
    Reviewed-by: Meghana M <mmadhusu at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Kaushal M <kaushal at redhat.com>

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1155042
[Bug 1155042] [USS] : don't display the snapshots which are not activated
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.