[Bugs] [Bug 1168809] logging improvement in glusterd

bugzilla at redhat.com bugzilla at redhat.com
Mon Dec 1 06:21:59 UTC 2014


https://bugzilla.redhat.com/show_bug.cgi?id=1168809



--- Comment #2 from Anand Avati <aavati at redhat.com> ---
COMMIT: http://review.gluster.org/9207 committed in master by Krishnan
Parthasarathi (kparthas at redhat.com) 
------
commit 4ad587a25ff218248f96696305d505c0d37c82f5
Author: Atin Mukherjee <amukherj at redhat.com>
Date:   Fri Nov 28 12:03:24 2014 +0530

    glusterd: logging improvement in txn_opinfo getter/setter function

    There is a code path (__glusterd_handle_stage_op) where
glusterd_get_txn_opinfo
    may fail to get a valid transaction id if there is no volume name provided
in
    the command, however if this function fails to get a txn id in op state
machine
    then its a serious issue and op-sm is impacted. From debugability aspect
gf_log
    () can never give the consumer of this function, so logging these failures
with
    gf_log_calling_fn is must here.

    Change-Id: I4937a9fb20cc6a747fd30dcd9fd4936398d0602a
    BUG: 1168809
    Signed-off-by: Atin Mukherjee <amukherj at redhat.com>
    Reviewed-on: http://review.gluster.org/9207
    Reviewed-by: Avra Sengupta <asengupt at redhat.com>
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas at redhat.com>
    Tested-by: Krishnan Parthasarathi <kparthas at redhat.com>

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are the assignee for the bug.


More information about the Bugs mailing list