[Gluster-Maintainers] [gluster-packaging] glusterfs-3.11.0 released

[Patrick Matthäi]

Am 02.06.2017 um 13:49 schrieb Niels de Vos:
> On Thu, Jun 01, 2017 at 10:55:34AM +0200, Patrick Matthäi wrote:
>
>> 1) gluster group: shouldn't the init script chgrp the statedump dir on
>> starting glusterfs? /run (or /var/run) are on most systems on tmpfs
> We use a tmpfiles.d/ snippet for that on systemd environments. Older RPM
> distributions do not have /var/run as tmpfs and the owner/group are
> properties of the RPM contents.

Thanks for your hint. I have added extras/run-gluster.tmpfiles.in to the
packaging.


>
>> 2) Patch 02-init-remote-fs.diff: please merge it
> This introduces a dependency for starting the glusterd management
> daemon. Before starting the daemon, the $remote_fs service(s) need to
> start. This will be a problem for fuse.glusterfs mountpoints that are
> listed in /etc/fstab. Can you explain why this is not a problem or if it
> is something that was missed?
I have dropped it now, too. Looks like the requirement on $remote_fs
(for a mounted /usr) is obsolete with Debian Stretch now.


>> 4) Patch 03-shell-script-syntax.diff: it fixes syntax errors with dash
>> and bash. To be checked by you is my change of $b(/.*)? to just $b -
>> cant recognize what do you try there. It fails in dash and bash

This "$b(/.*)?" issue is still there:

E: glusterfs-server: shell-script-fails-syntax-check
var/lib/glusterd/hooks/1/create/post/S10selinux-label-brick.sh
N:
N:    Running this shell script with the shell's -n option set fails, which
N:    means that the script has syntax errors. The most common cause of this
N:    problem is a script expecting /bin/sh to be bash checked on a system
N:    using dash as /bin/sh.
N:
N:    Run e.g. sh -n yourscript to see the errors yourself.

me at srv1:~/build/glusterfs-3.11.1$ LC_ALL=C bash -n
./extras/hook-scripts/create/post/S10selinux-label-brick.sh
./extras/hook-scripts/create/post/S10selinux-label-brick.sh: line 46:
syntax error near unexpected token `('
./extras/hook-scripts/create/post/S10selinux-label-brick.sh: line 46:
`                semanage fcontext --add -t glusterd_brick_t -r s0 $b(/.*)?'

me at srv1:~/build/glusterfs-3.11.1$ LC_ALL=C dash -n
./extras/hook-scripts/create/post/S10selinux-label-brick.sh
./extras/hook-scripts/create/post/S10selinux-label-brick.sh: 46:
./extras/hook-scripts/create/post/S10selinux-label-brick.sh: Syntax
error: "(" unexpected (expecting "done")

-- 
/*
Mit freundlichem Gruß / With kind regards,
 Patrick Matthäi
 GNU/Linux Debian Developer

  Blog: http://www.linux-dev.org/
E-Mail: pmatthaei at debian.org
        patrick at linux-dev.org
*/


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://lists.gluster.org/pipermail/maintainers/attachments/20170630/914f10ee/attachment.sig>