[Gluster-Maintainers] [Gluster-devel] 'Reviewd-by' tag for commits

[Michael Adam]

On 2016-10-16 at 02:04 +0530, Pranith Kumar Karampuri wrote:
> Which review-tool do you suggest Michael? Any other alternatives that are
> better? Don't tell me email :-)

Well, for no tool/vehicle is perfect, each sucks in some respect.
Quite frankly, of the few I have seen so far, email just sucks least,
and gerrit sucks most. That's just me, and I could elaborate, but
I won't bother you since I am obviously not one of the main
contributors to Gluster, and those should probably have the
strongest voice! :-)

Here is an interesting read on the topic:

https://lwn.net/SubscriberLink/702177/d0f5decfbb3cb619/

And I am certainly not trying to convince you from
moving away from Gerrit right now - there is more
important stuff to do - but my advice is to refrain
from getting involved deeper with Gerrit by forking
it and customizing the code.

The git logs will survive, and with them, any tags in
the commit messages -- no matter which tool created them.

Cheers - Michael


> On Sun, Oct 16, 2016 at 1:20 AM, Michael Adam <obnox at samba.org> wrote:
> 
> > On 2016-10-14 at 11:44 +0200, Niels de Vos wrote:
> > > On Fri, Oct 14, 2016 at 02:21:23PM +0530, Nigel Babu wrote:
> > > > I've said on this thread before, none of this is easy to do. It needs
> > us to
> > > > fork Gerrit to make our own changes. I would argue that depending on
> > the
> > > > data from the commit message is folly.
> > >
> > > Eventhough we all seem to agree that statistics based on commit messages
> > > is not correct,
> >
> > I think it is the best we can currently offer.
> > Let's be honest: Gerrit sucks. Big time!
> > If gerrit is no more, the git logs will survive.
> > Git is the common denominator that will last,
> > with all the tags that the commit messages carry.
> > So for now, I'd say the more tags we can fit into
> > git commit mesages the better... :-)
> >
> > > it looks like it is an incentive to get reviewing valued
> > > more. We need to promote the reviewing work somehow, and this is one way
> > > to do it.
> > >
> > > Forking Gerrit is surely not the right thing.
> >
> > Right. Avoid it if possible. Did I mention gerrit sucks? ;-)
> >
> > Cheers - Michael
> >
> >
> 
> 
> -- 
> Pranith
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 163 bytes
Desc: not available
URL: <http://www.gluster.org/pipermail/maintainers/attachments/20161016/52c3118b/attachment.sig>