[Gluster-Maintainers] New Defects reported by Coverity Scan for gluster/glusterfs

Niels de Vos ndevos at redhat.com
Thu Jul 21 07:16:01 UTC 2016


Vijay, I've fwd'd the original report. Could you add this list on the
receipients of the run?

On Wed, Jul 20, 2016 at 09:39:40PM -0700, scan-admin at coverity.com wrote:
...
> ** CID 1357867:  Control flow issues  (NESTING_INDENT_MISMATCH)
> /home/vijay/workspace/glusterfs/glusterfs/xlators/performance/md-cache/src/md-cache.c: 2568 in notify()
> 
> 
> ________________________________________________________________________________________________________
> *** CID 1357867:  Control flow issues  (NESTING_INDENT_MISMATCH)
> /home/vijay/workspace/glusterfs/glusterfs/xlators/performance/md-cache/src/md-cache.c: 2568 in notify()
> 2562                     mdc_update_child_down_time (this, &now);
> 2563                     ret = default_notify (this, event, data);
> 2564                     break;
> 2565             case GF_EVENT_UPCALL:
> 2566                     if (conf->mdc_invalidation)
> 2567                             ret = mdc_invalidate (this, data);
> >>>     CID 1357867:  Control flow issues  (NESTING_INDENT_MISMATCH)
> >>>     This 'if'  statement is indented to column 25, as if it were nested within the preceding parent statement, but it is not.
> 2568                             if (default_notify (this, event, data) != 0)
> 2569                                     ret = -1;
> 2570                     break;
> 2571             default:
> 2572                     ret = default_notify (this, event, data);
> 2573                     break;

Addressed with http://review.gluster.org/14971

Niels
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://www.gluster.org/pipermail/maintainers/attachments/20160721/b7a0828d/attachment.sig>


More information about the maintainers mailing list