[GEDI] [PATCH v3 05/25] scripts: add coccinelle script to fix error_append_hint usage

Eric Blake eblake at redhat.com
Tue Sep 24 20:52:00 UTC 2019


On 9/24/19 3:08 PM, Vladimir Sementsov-Ogievskiy wrote:
> error_append_hint will not work, if errp == &fatal_error, as program
> will exit before error_append_hint call. Fix this by use of special
> macro ERRP_FUNCTION_BEGIN.
> 
> Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov at virtuozzo.com>
> ---

>  .../fix-error_append_hint-usage.cocci         | 25 +++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 scripts/coccinelle/fix-error_append_hint-usage.cocci
> 

> +}
> +
> 

Why are you creating a file with a trailing blank line?

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3226
Virtualization:  qemu.org | libvirt.org


More information about the integration mailing list