[GEDI] [PATCH v3 00/25] error: auto propagated local_err
Vladimir Sementsov-Ogievskiy
vsementsov at virtuozzo.com
Tue Sep 24 20:08:37 UTC 2019
Hi all!
Here is a proposal of auto propagation for local_err, to not call
error_propagate on every exit point, when we deal with local_err.
There are also two issues with errp:
1. error_fatal & error_append_hint: user can't see these
hints, because exit() happens in error_setg earlier than hint is
appended. [Reported by Greg Kurz]
2. error_abort & error_propagate: when we wrap
error_abort by local_err+error_propagate, resulting coredump will
refer to error_propagate and not to the place where error happened.
(the macro itself don't fix the issue, but it allows to [3.] drop all
local_err+error_propagate pattern, which will definitely fix the issue)
[Reported by Kevin Wolf]
Still, applying new macro to all errp-functions is a huge task, which is
impossible to solve in one series.
So, here is a minimum: solve only [1.], by adding new macro to all
errp-functions which wants to call error_append_hint.
v3: plan B: fix only error_append_hint users, as a first step.
01: - new errp-based API dropped, so now patch is smaller.
- slightly adjust commit message
- keep Eric's r-b
02: - no new API, so just open-code fix
- keep Eric's r-b
03: - simplify the code [Eric]
04: - grammar and wording
- drop extra unused variable
others: new
Vladimir Sementsov-Ogievskiy (25):
errp: rename errp to errp_in where it is IN-argument
hw/core/loader-fit: fix freeing errp in fit_load_fdt
net/net: fix local variable shadowing in net_client_init
error: auto propagated local_err
scripts: add coccinelle script to fix error_append_hint usage
python: add commit-per-subsystem.py
s390: Fix error_append_hint usage
ARM TCG CPUs: Fix error_append_hint usage
PowerPC TCG CPUs: Fix error_append_hint usage
arm: Fix error_append_hint usage
SmartFusion2: Fix error_append_hint usage
PCI: Fix error_append_hint usage
SCSI: Fix error_append_hint usage
USB: Fix error_append_hint usage
VFIO: Fix error_append_hint usage
virtio: Fix error_append_hint usage
virtio-9p: Fix error_append_hint usage
block: Fix error_append_hint usage
chardev: Fix error_append_hint usage
cmdline: Fix error_append_hint usage
QOM: Fix error_append_hint usage
Migration: Fix error_append_hint usage
Sockets: Fix error_append_hint usage
nbd: Fix error_append_hint usage
PVRDMA: Fix error_append_hint usage
include/monitor/hmp.h | 2 +-
include/qapi/error.h | 37 +++++++++-
ui/vnc.h | 2 +-
block/backup.c | 1 +
block/dirty-bitmap.c | 1 +
block/file-posix.c | 3 +
block/gluster.c | 2 +
block/qcow.c | 1 +
block/qcow2.c | 1 +
block/vhdx-log.c | 1 +
block/vpc.c | 1 +
chardev/spice.c | 1 +
hw/9pfs/9p-local.c | 1 +
hw/9pfs/9p-proxy.c | 1 +
hw/arm/msf2-soc.c | 1 +
hw/arm/virt.c | 2 +
hw/core/loader-fit.c | 1 +
hw/intc/arm_gicv3_kvm.c | 1 +
hw/misc/msf2-sysreg.c | 1 +
hw/pci-bridge/pcie_root_port.c | 1 +
hw/ppc/mac_newworld.c | 1 +
hw/ppc/spapr.c | 1 +
hw/ppc/spapr_pci.c | 1 +
hw/rdma/vmw/pvrdma_main.c | 1 +
hw/s390x/s390-ccw.c | 1 +
hw/scsi/scsi-disk.c | 1 +
hw/scsi/scsi-generic.c | 1 +
hw/usb/ccid-card-emulated.c | 1 +
hw/vfio/common.c | 2 +
hw/vfio/pci.c | 2 +
hw/virtio/virtio-pci.c | 2 +
migration/migration.c | 1 +
monitor/hmp-cmds.c | 8 +--
nbd/client.c | 1 +
nbd/server.c | 1 +
net/net.c | 17 ++---
qdev-monitor.c | 2 +
target/ppc/kvm.c | 2 +
ui/vnc.c | 10 +--
util/error.c | 8 +--
util/qemu-option.c | 2 +
util/qemu-sockets.c | 2 +
python/commit-per-subsystem.py | 69 +++++++++++++++++++
.../fix-error_append_hint-usage.cocci | 25 +++++++
44 files changed, 198 insertions(+), 26 deletions(-)
create mode 100755 python/commit-per-subsystem.py
create mode 100644 scripts/coccinelle/fix-error_append_hint-usage.cocci
CC: John Snow <jsnow at redhat.com>
CC: Kevin Wolf <kwolf at redhat.com>
CC: Max Reitz <mreitz at redhat.com>
CC: Fam Zheng <fam at euphon.net>
CC: Jeff Cody <codyprime at gmail.com>
CC: "Marc-André Lureau" <marcandre.lureau at redhat.com>
CC: Paolo Bonzini <pbonzini at redhat.com>
CC: Greg Kurz <groug at kaod.org>
CC: Subbaraya Sundeep <sundeep.lkml at gmail.com>
CC: Peter Maydell <peter.maydell at linaro.org>
CC: Paul Burton <pburton at wavecomp.com>
CC: Aleksandar Rikalo <arikalo at wavecomp.com>
CC: "Michael S. Tsirkin" <mst at redhat.com>
CC: Marcel Apfelbaum <marcel.apfelbaum at gmail.com>
CC: Mark Cave-Ayland <mark.cave-ayland at ilande.co.uk>
CC: David Gibson <david at gibson.dropbear.id.au>
CC: Yuval Shaia <yuval.shaia at oracle.com>
CC: Cornelia Huck <cohuck at redhat.com>
CC: Eric Farman <farman at linux.ibm.com>
CC: Richard Henderson <rth at twiddle.net>
CC: David Hildenbrand <david at redhat.com>
CC: Halil Pasic <pasic at linux.ibm.com>
CC: Christian Borntraeger <borntraeger at de.ibm.com>
CC: Gerd Hoffmann <kraxel at redhat.com>
CC: Alex Williamson <alex.williamson at redhat.com>
CC: Markus Armbruster <armbru at redhat.com>
CC: Michael Roth <mdroth at linux.vnet.ibm.com>
CC: Juan Quintela <quintela at redhat.com>
CC: "Dr. David Alan Gilbert" <dgilbert at redhat.com>
CC: Eric Blake <eblake at redhat.com>
CC: Jason Wang <jasowang at redhat.com>
CC: "Daniel P. Berrangé" <berrange at redhat.com>
CC: Eduardo Habkost <ehabkost at redhat.com>
CC: qemu-block at nongnu.org
CC: qemu-devel at nongnu.org
CC: integration at gluster.org
CC: qemu-arm at nongnu.org
CC: qemu-ppc at nongnu.org
CC: qemu-s390x at nongnu.org
--
2.21.0
More information about the integration
mailing list