[Gluster-users] Feedback on CLI message outputs

[James]

Haha, actually it was this guy ;)

Here is the example code (python) i'm using:

# 	EXAMPLE:
#	$ gluster volume --xml info <VOLNAME> | ./xml.py <KEY>
#	<VALUE>

import sys
import lxml.etree as etree

if len(sys.argv) != 2:
	sys.exit(1)

t = etree.parse(sys.stdin)
r = t.getroot()
v = [x.find('value').text for x in r.findall('.//option') if
x.find('name').text == str(sys.argv[1])]
if len(v) == 1:
	print v[0]
	sys.exit(0)
else:			# more than one value found
	sys.exit(1)

While this is somewhat ridiculous, I don't mind doing it, because it's
done, and it's the only way I know of to "get" an option value. Hint,
hint: feature request.

This will appear in my git repo shortly...

James

PS: It seems that this only shows values which are set differently than
the defaults. It would be excellent to change this approach, so that
scripts (like puppet) can reliably know if the key they're watching is
different from what it wants to set it to, without having to have a
table of the defaults) If this doesn't make sense I can re-explain...

On Mon, 2012-08-06 at 20:11 -0700, Joe Julian wrote:
> Those darned IRC people, always advising people to use undocumented
> options... Sheesh.
> 
> On 08/06/2012 07:10 PM, James wrote: 
> > On Tue, 2012-08-07 at 07:33 +0530, Kaushal M wrote:
> > > Hi James,
> > > This is the first time I've heard of someone in the community using
> > > the '--xml' flag.
> > Cool :) I'll be posting my updated code that uses this in my
> > https://github.com/purpleidea/puppet-gluster shortly. The --xml flag was
> > suggested by someone in irc, as a stable alternative to parsing the
> > normal command line output (messy).
> > 
> > > This flag has not been tested extensively, so there are bound to be
> > > some errors, inconsistencies and incompleteness. We are trying to fix
> > > it and stabilize it as much as possible. So if you do find any bugs
> > > (which you will) please report them.
> > Will do :) It seems to be working at the moment 3.3
> > 
> > James
> > 
> > > Cheers,
> > > Kaushal
> > > 
> > > On 7 Aug 2012 01:58, "James" <purpleidea at gmail.com> wrote:
> > >         Hi there,
> > >         
> > >         I'm currently using the --xml flag when running gluster via
> > >         automatic
> > >         scripts such as via puppet exec. Please keep this stable :)
> > >         
> > >         Thank you!
> > >         James
> > >         
> > >         
> > >         On Mon, 2012-08-06 at 12:31 +0530, Amar Tumballi wrote:
> > >         > Hi All,
> > >         >
> > >         > We are in the process of improving our log messages, and
> > >         message outputs
> > >         > through CLI. As a first step, we want to make sure our CLI
> > >         outputs are
> > >         > both meaningful and script friendly (for people who want to
> > >         use the CLI
> > >         > output in their scripts).
> > >         >
> > >         > We are taking few baby steps in this regard in upstream
> > >         (master branch).
> > >         > I recently sent a patch http://review.gluster.com/3753 which
> > >         tries to
> > >         > separate out most of the error messages by outputting it to
> > >         stderr
> > >         > instead of stdout.
> > >         >
> > >         > In the meantime, I tried to keep it script friendly too.
> > >         With that patch
> > >         > going in, the problem is, if any of you have written scripts
> > >         which greps
> > >         > for specific pattern in the CLI output, will be broken when
> > >         the next
> > >         > major release happens.
> > >         >
> > >         > So, I want your feed back on getting it right by involving
> > >         you all to
> > >         > make the messages more friendlier to both script writers,
> > >         and also to
> > >         > admins who would understand the messages properly. (ie,
> > >         meaning of the
> > >         > messages should be unambiguous).
> > >         >
> > >         > To try to see the difference in CLI outputs, you need to
> > >         checkout git
> > >         > repo, and build locally, as there are no releases available
> > >         at the moment.
> > >         >
> > >         >
> > >         > Thanks and Regards,
> > >         > Amar
> > >         > _______________________________________________
> > >         > Gluster-users mailing list
> > >         > Gluster-users at gluster.org
> > >         > http://gluster.org/cgi-bin/mailman/listinfo/gluster-users
> > >         
> > >         
> > >         _______________________________________________
> > >         Gluster-users mailing list
> > >         Gluster-users at gluster.org
> > >         http://gluster.org/cgi-bin/mailman/listinfo/gluster-users
> > >         
> > > 
> > > 
> > > _______________________________________________
> > > Gluster-users mailing list
> > > Gluster-users at gluster.org
> > > http://gluster.org/cgi-bin/mailman/listinfo/gluster-users
> _______________________________________________
> Gluster-users mailing list
> Gluster-users at gluster.org
> http://gluster.org/cgi-bin/mailman/listinfo/gluster-users

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://supercolony.gluster.org/pipermail/gluster-users/attachments/20120806/1d14d046/attachment.sig>