[Gluster-users] Request for user comments

[Ravishankar N]

On 06/17/2015 10:10 PM, Pranith Kumar Karampuri wrote:
>
>
> On 06/17/2015 09:28 PM, Ravishankar N wrote:
>> Hello,
>>
>> I sent a patch [1] to print the backtrace generated by 
>> 'gf_log_callingfn' (only) in a human-readable way. While it improves 
>> readability by printing every function of the backtrace in a separate 
>> line (which is how a backtrace *should* look), it violates the fact 
>> that every log in gluster gets logged in a single line. Does anyone 
>> see any problem with this? Especially sys-admins who might have 
>> scripts/ mechanisms to parse logs? Note that the patch affects only 
>> messages logged using gf_log_callingfn() and is avoids eyesore.
> Grepping logs will be difficult with this change. May be we can use 
> something like:

Could you elaborate? IMO, `grep -A10 gf_log_callingfn <logfile.log>` to 
list the backtrace seems a lot easier than typing that substitution pattern.

> sed 's/(-->/\n(-->/g' <logfile.log> to achieve the same?

>
> Pranith
>>
>> Thanks,
>> Ravi
>>
>>
>> [1] http://review.gluster.org/#/c/11217/1
>> _______________________________________________
>> Gluster-users mailing list
>> Gluster-users at gluster.org
>> http://www.gluster.org/mailman/listinfo/gluster-users
>