[Gluster-infra] [Bug 1584992] Need python pep8 and other relevant tests in smoke if a patch includes any python file

bugzilla at redhat.com bugzilla at redhat.com
Tue Jul 3 09:03:09 UTC 2018


--- Comment #4 from Nigel Babu <nigelb at redhat.com> ---
So re: python3 validation. I ran pylint --py3k across the codebase today and it
showed me zero errors. However, running 2to3 for our python files shows me a
lot of dict.iteritems() which should be dict.items() in python3 (Kaleb has a
patch to fix them already). This still doesn't catch more subtler bugs like
python's division operator changing behavior in python3

5 / 2 = 2

5 / 2 = 2.5

2to3 doesn't catch this change. In essence, we can add automation, but we
warned that the automation passing does not actually mean that we're 100% in
the clear with regard to python3 support. That will need some in-depth testing
and there's no way around that.

You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=MwYIvjZah6&a=cc_unsubscribe

More information about the Gluster-infra mailing list