[Gluster-infra] [Bug 1431199] New: Request to automate closing github PRs

bugzilla at redhat.com bugzilla at redhat.com
Fri Mar 10 15:07:10 UTC 2017


            Bug ID: 1431199
           Summary: Request to automate closing github PRs
           Product: GlusterFS
           Version: mainline
         Component: project-infrastructure
          Priority: medium
          Assignee: bugs at gluster.org
          Reporter: srangana at redhat.com
                CC: bugs at gluster.org, gluster-infra at gluster.org

This request is discussed here:

We do not accept github PRs as our work flow is gerrit based.

To educate contributors, one of the things we could do is to put up a 
template as in [1] for the PULL_REQUEST_TEMPLATE. It will look like this 
[2] when users attempt to submit PRs.

An alternate idea suggested by Nigel was to accept PRs, but use a 
Jenkins job to auto close the same, with some generic (or very specific) 
instructions on how to submit it to our gerrit instance.

The advantage of the latter method is that we do not lose the code 
change suggested, and we can still evaluate the same and reach out to 
the contributor and also possibly get the change into our gerrit instance.

The latter approach looks good, and we would like to have this inplemented.
This bug is being raised for the same.

Also, this is not an urgent requirement, this can happen in the next month or
beyond, as this does not change anything major for us at the moment.

[1] PR template: 

[2] How a PR template appears to contributors: 

You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=ONYxiJXfeZ&a=cc_unsubscribe

More information about the Gluster-infra mailing list