[Gluster-infra] [Bug 1428047] Require a Jenkins job to validate Change-ID on commits to branches in glusterfs repository

bugzilla at redhat.com bugzilla at redhat.com
Mon Apr 10 09:10:02 UTC 2017


--- Comment #6 from Worker Ant <bugzilla-bot at gluster.org> ---
COMMIT: https://review.gluster.org/17004 committed in master by Niels de Vos
(ndevos at redhat.com) 
commit 788def7912c68616849748678574c60a52021e3c
Author: Shyam <srangana at redhat.com>
Date:   Wed Apr 5 14:22:57 2017 -0400

    scripts: Update rfc.sh to check existance of Change-Id in backports

    Addition to this script is a no-op on master.

    This would need to be backported to active release branches to be

    This check is not smart proof, in that someone could proceed knowing
    that the Change-Id differs from master, but this is not expected to
    catch that, instead it is to serve more as a reminder that we need
    the same Change-Id across branches.

    Contributors not using rfc.sh would not see this, but they are few
    and possibly far in between. Also contributors using gerrit to
    cherry-pick changes will not see this. For both cases a server side
    solution to catch any changes are needed.

    There is a possiblilty that we will follow this up with a check
    on the gerrit end and add a comment to the reviews, to aid reviewers
    to quickly check the sanity of the Change-Id when it differs.

    Change-Id: I11e371489a4a3cf2ff96d9892256986cd535998b
    BUG: 1428047
    Signed-off-by: Shyam <srangana at redhat.com>
    Reviewed-on: https://review.gluster.org/17004
    Smoke: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Niels de Vos <ndevos at redhat.com>
    NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
    CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
    Reviewed-by: Kaleb KEITHLEY <kkeithle at redhat.com>
    Reviewed-by: Amar Tumballi <amarts at redhat.com>

You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=eYhJ2ruBlV&a=cc_unsubscribe

More information about the Gluster-infra mailing list