[Gluster-devel] NFS Ganesha fails to export a volume

[Strahil Nikolov]

I can try to help with the testing (I'm quite new to that).
Can someone share documentation of that process ?

yet we have another problem -> ganesha is deployed with ocf:heartbeat:portblock which supports only IPTABLES, while EL8 uses NFTABLES ...

Best Regards,
Strahil Nikolov






В понеделник, 16 ноември 2020 г., 10:47:43 Гринуич+2, Yaniv Kaul <ykaul at redhat.com> написа: 







On Mon, Nov 16, 2020 at 10:26 AM Ravishankar N <ravishankar at redhat.com> wrote:
> 
> On 15/11/20 8:24 pm, Strahil Nikolov wrote:
>> Hello All,
>>
>> did anyone get a chance to look at https://github.com/gluster/glusterfs/issues/1778 ?
> 
> A look at 
> https://review.gluster.org/#/c/glusterfs/+/23648/4/xlators/mgmt/glusterd/src/glusterd-op-sm.c@1117 
> seems to indicate this could be due to a typo error. Do you have a 
> source install where you can apply this simple diff and see if it fixes 
> the issue?

I think you are right - I seem to have introduced it as part of https://github.com/gluster/glusterfs/commit/e081ac683b6a5bda54891318fa1e3ffac981e553 - my bad.

However, it was merged ~1 year ago, and no one has complained thus far... :-/
1. Is no one using NFS Ganesha? 
2. We are lacking tests for NFS Ganesha - code coverage indicates this path is not covered.

Y.

>  
> diff --git a/xlators/mgmt/glusterd/src/glusterd-op-sm.c 
> b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
> index 558f04fb2..d7bf96adf 100644
> --- a/xlators/mgmt/glusterd/src/glusterd-op-sm.c
> +++ b/xlators/mgmt/glusterd/src/glusterd-op-sm.c
> @@ -1177,7 +1177,7 @@ glusterd_op_stage_set_volume(dict_t *dict, char 
> **op_errstr)
>               }
>           } else if (len_strcmp(key, keylen, "ganesha.enable")) {
>               key_matched = _gf_true;
> -            if (!strcmp(value, "off") == 0) {
> +            if (strcmp(value, "off") == 0) {
>                   ret = ganesha_manage_export(dict, "off", _gf_true, 
> op_errstr);
>                   if (ret)
>                       goto out;
> 
> Thanks,
> 
> Ravi
>>
>> It's really strange that NFS Ganesha has ever passed the tests.
>> How do we test NFS Ganesha exporting ?
>>
>> Best Regards,
>> Strahil Nikolov
>> _______________________________________________
>>
>> Community Meeting Calendar:
>>
>> Schedule -
>> Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
>> Bridge: https://bluejeans.com/441850968
>>
>>
>>
>>
>> Gluster-devel mailing list
>> Gluster-devel at gluster.org
>> https://lists.gluster.org/mailman/listinfo/gluster-devel
> 
>>
> 
> _______________________________________________
> 
> Community Meeting Calendar:
> 
> Schedule -
> Every 2nd and 4th Tuesday at 14:30 IST / 09:00 UTC
> Bridge: https://bluejeans.com/441850968
> 
> 
> 
> 
> Gluster-devel mailing list
> Gluster-devel at gluster.org
> https://lists.gluster.org/mailman/listinfo/gluster-devel
> 
>