[Gluster-devel] Failure during “git review –setup”

[Saleh, Amgad (Nokia - US/Naperville)]

Never mind – It worked. The $USER when adding the remote gerrit should be my github user, documentation was not clear!

From: Saleh, Amgad (Nokia - US/Naperville)
Sent: Thursday, May 23, 2019 11:34 PM
To: gluster-devel at gluster.org
Subject: RE: Failure during “git review –setup”
Importance: High


Looking at the document https://gluster.readthedocs.io/en/latest/Developer-guide/Simplified-Development-Workflow/
I ran ./rfc.sh and got the following:

[ahsaleh at null-d4bed9857109 glusterfs]$ ./rfc.sh
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  4780  100  4780    0     0    438      0  0:00:10  0:00:10 --:--:--  1087
[bugfix-pureIPv6 d14e550] Return IPv6 when exists and not -1
1 file changed, 10 insertions(+), 5 deletions(-)
Commit: "Return IPv6 when exists and not -1"
Reference (Bugzilla ID or Github Issue ID): amgads
Invalid reference ID (amgads)!!!
Commit: "Return IPv6 when exists and not -1"
Reference (Bugzilla ID or Github Issue ID): amgads
Invalid reference ID (amgads)!!!
Commit: "Return IPv6 when exists and not -1"
Reference (Bugzilla ID or Github Issue ID): 677
Select yes '(y)' if this patch fixes the bug/feature completely,
or is the last of the patchset which brings feature (Y/n): y
[detached HEAD 8a5bb4a] Return IPv6 when exists and not -1
1 file changed, 10 insertions(+), 5 deletions(-)
Successfully rebased and updated refs/heads/bugfix-pureIPv6.
./rfc.sh: line 287: clang-format: command not found
[ahsaleh at null-d4bed9857109 glusterfs]$

Is the code submitted for review?  Please advise what’s needd next – this is my first time to use the process

Submit for review
To submit your change for review, run the rfc.sh script,
    $ ./rfc.sh


From: Saleh, Amgad (Nokia - US/Naperville)
Sent: Thursday, May 23, 2019 11:19 PM
To: gluster-devel at gluster.org<mailto:gluster-devel at gluster.org>
Subject: Failure during “git review –setup”


Hi:

After submitting a Pull Request at Github. I got the message about the gerrit review (attached)
I follow the steps, added a public key but failed at the “git review –setup” step – please see errors below

Your urgent support is appreciated!

Regards,
Amgad Saleh
Nokia.
……
[ahsaleh at null-d4bed9857109 glusterfs]$ git review --setup
Problem running 'git remote update gerrit'
Fetching gerrit
Permission denied (publickey).
fatal: Could not read from remote repository.

Please make sure you have the correct access rights
and the repository exists.
error: Could not fetch gerrit
Problems encountered installing commit-msg hook
The following command failed with exit code 1
    "scp ahsaleh at review.gluster.org:hooks/commit-msg<mailto:ahsaleh at review.gluster.org:hooks/commit-msg> .git/hooks/commit-msg"
-----------------------
Permission denied (publickey).
-----------------------
[ahsaleh at null-d4bed9857109 glusterfs]$

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gluster.org/pipermail/gluster-devel/attachments/20190524/559a0bd9/attachment-0001.html>