[Gluster-devel] Query regarding dictionary logic

[Mohit Agrawal]

sure Vijay, I will try and update.

Regards,
Mohit Agrawal

On Tue, Apr 30, 2019 at 11:44 AM Vijay Bellur <vbellur at redhat.com> wrote:

> Hi Mohit,
>
> On Mon, Apr 29, 2019 at 7:15 AM Mohit Agrawal <moagrawa at redhat.com> wrote:
>
>> Hi All,
>>
>>   I was just looking at the code of dict, I have one query current
>> dictionary logic.
>>   I am not able to understand why we use hash_size is 1 for a
>> dictionary.IMO with the
>>   hash_size of 1 dictionary always work like a list, not a hash, for
>> every lookup
>>   in dictionary complexity is O(n).
>>
>>   Before optimizing the code I just want to know what was the exact
>> reason to define
>>   hash_size is 1?
>>
>
> This is a good question. I looked up the source in gluster's historic repo
> [1] and hash_size is 1 even there. So, this could have been the case since
> the first version of the dictionary code.
>
> Would you be able to run some tests with a larger hash_size and share your
> observations?
>
> Thanks,
> Vijay
>
> [1]
> https://github.com/gluster/historic/blob/master/libglusterfs/src/dict.c
>
>
>
>>
>>   Please share your view on the same.
>>
>> Thanks,
>> Mohit Agrawal
>> _______________________________________________
>> Gluster-devel mailing list
>> Gluster-devel at gluster.org
>> https://lists.gluster.org/mailman/listinfo/gluster-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gluster.org/pipermail/gluster-devel/attachments/20190430/e781b6ac/attachment.html>