[Gluster-devel] Python3 build process

[Kaleb S. KEITHLEY]

On 9/27/18 8:40 AM, Shyam Ranganathan wrote:
> On 09/27/2018 08:07 AM, Kaleb S. KEITHLEY wrote:
>>> The thought is,
>>> - Add a configure option "--enable-py-version-correction" to configure,
>>> that is disabled by default
>> "correction" implies there's something that's incorrect. How about
>> "conversion" or perhaps just --enable-python2
>>
> 
> I would not like to go with --enable-python2 as that implies it is an
> conscious choice with the understanding that py2 is on the box. Given
> the current ability to detect and hence correct the python shebangs, I
> would think we should retain it as a more detect and modify the shebangs
> option name. (I am looking at this more as an option that does the right
> thing implicitly than someone/tool using this checking explicitly, which
> can mean different things to different people, if that makes sense)
> 
> Now "correction" seems like an overkill, maybe "conversion"?
> 

I guess I don't really care what the option is called.

The only conversion is _to_ python2 and the only place it ever _needs_
to be done is RHEL < 8 and eventually CentOS < 8.

(You could argue that python3 -> python3 is a conversion.) Are you
saying that if you do `./configure --enable-py-version-conversion` on,
e.g. a Fedora < 30 box, that the shebangs will still be
#!/usr/bin/python3 because python3 is on the box? I think that would be
surprising.

I can imagine that someone might want to convert them on Fedora < 30 and
Debian/Ubuntu/etc because they want to _test_ that the python bits still
work with python2. (Or they actually want to use python2 over python3
for some reason.)

--

Kaleb