[Gluster-devel] Fwd: New Defects reported by Coverity Scan for gluster/glusterfs

[Yaniv Kaul]

On Tue, Nov 6, 2018, 5:51 PM Atin Mukherjee <atin.mukherjee83 at gmail.com
wrote:

> new defects introduced in posix xlator.
>

The other one in iobuf.c, is mine.
Sent a patch to fix.
Y.


> ---------- Forwarded message ---------
> From: <scan-admin at coverity.com>
> Date: Tue, Nov 6, 2018 at 8:44 PM
> Subject: New Defects reported by Coverity Scan for gluster/glusterfs
>
> Hi,
>
> Please find the latest report on new defect(s) introduced to
> gluster/glusterfs found with Coverity Scan.
>
> 2 new defect(s) introduced to gluster/glusterfs found with Coverity Scan.
> 1 defect(s), reported by Coverity Scan earlier, were marked fixed in the
> recent build analyzed by Coverity Scan.
>
> New defect(s) Reported-by: Coverity Scan
> Showing 2 of 2 defect(s)
>
>
> ** CID 1396581:  Program hangs  (LOCK)
> /xlators/features/locks/src/posix.c: 2952 in pl_metalk()
>
>
>
> ________________________________________________________________________________________________________
> *** CID 1396581:  Program hangs  (LOCK)
> /xlators/features/locks/src/posix.c: 2952 in pl_metalk()
> 2946                 gf_msg(this->name, GF_LOG_WARNING, EINVAL, 0,
> 2947                        "More than one meta-lock can not be granted on"
> 2948                        "the inode");
> 2949                 ret = -1;
> 2950             }
> 2951         }
> >>>     CID 1396581:  Program hangs  (LOCK)
> >>>     "pthread_mutex_lock" locks "pl_inode->mutex" while it is locked.
> 2952         pthread_mutex_lock(&pl_inode->mutex);
> 2953
> 2954         if (ret == -1) {
> 2955             goto out;
> 2956         }
> 2957
>
> ** CID 1396580:  Program hangs  (LOCK)
> /libglusterfs/src/iobuf.c: 370 in iobuf_pool_new()
>
>
>
> ________________________________________________________________________________________________________
> *** CID 1396580:  Program hangs  (LOCK)
> /libglusterfs/src/iobuf.c: 370 in iobuf_pool_new()
> 364                 index = gf_iobuf_get_arena_index(page_size);
> 365                 if (index == -1) {
> 366                     gf_msg("iobuf", GF_LOG_ERROR, 0,
> LG_MSG_PAGE_SIZE_EXCEEDED,
> 367                            "page_size (%zu) of iobufs in arena being
> added is "
> 368                            "greater than max available",
> 369                            page_size);
> >>>     CID 1396580:  Program hangs  (LOCK)
> >>>     Returning without unlocking "iobuf_pool->mutex".
> 370                     return NULL;
> 371                 }
> 372
> 373                 __iobuf_pool_add_arena(iobuf_pool, page_size,
> num_pages, index);
> 374
> 375                 arena_size += page_size * num_pages;
>
>
>
> ________________________________________________________________________________________________________
> To view the defects in Coverity Scan visit,
> https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZBK54bFWohdObZ6wlkeK264nDC24cnLwH4MTOSDXRjQcO27-2F6DmQXPB4g4Mz-2BEJJ0-3D_MGdSxOtVesORpvKsy8XkEUz8gK23WuwInCh-2FVRcDCRF-2Fj7GTDPoxcf-2B4XMSxuE0IKzpwOxTNSoVvntYrckk7boSm-2BfDbr6brN0Go6MddV5Ve8QVPSgbNWXWvZ7l1kLdk6GNEGmAZfIuiGDDWWN8sx8sq3vuMKn14pdt5Dv916hJB1YBm6se3B-2B0HzsV8OiB1EdmLAFIpB4junx8QKmFhR-2FUt5daF2sDOaZ1cRkYuqrw-3D
>
>   To manage Coverity Scan email notifications for "
> atin.mukherjee83 at gmail.com", click
> https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4F4Na18V6TzekbRgLfnxbftCtNrSI0AdVE2H7Oze59ZO0QossEy3LBj8V8EoFBmLcCGWfAfPSpkvjpvSyEnHW4SE-2Fd5u6fIUaVdSUke9RseU-3D_MGdSxOtVesORpvKsy8XkEUz8gK23WuwInCh-2FVRcDCRF-2Fj7GTDPoxcf-2B4XMSxuE0IKzpwOxTNSoVvntYrckk7br4BV1h3eau0ij-2FPQQMBwjWfb83EERG8p56mMUZaClbKCzp3OMlM3vA-2B7Ttl8BucMYLPJn8w88855lzmJEHYTRQuUCNjxuwJwiDEl33K-2BkAuTC-2BA454wNMDJ0c-2FuhgLZOKALtX5AcGsYqywXMXpLzAc-3D
>
> _______________________________________________
> Gluster-devel mailing list
> Gluster-devel at gluster.org
> https://lists.gluster.org/mailman/listinfo/gluster-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gluster.org/pipermail/gluster-devel/attachments/20181106/79f7cee0/attachment.html>