[Gluster-devel] two potential memory leak place found on glusterfs 3.12.3

[Atin Mukherjee]

+Gaurav

On Mon, Feb 26, 2018 at 2:02 PM, Raghavendra Gowdappa <rgowdapp at redhat.com>
wrote:

> +glusterd devs
>
> On Mon, Feb 26, 2018 at 1:41 PM, Storage, Dev (Nokia - Global) <
> dev.storage at nokia.com> wrote:
>
>> Hi glusterfs experts,
>>
>>        Good day!
>>
>>        During our recent test we found that after execute some glusterfs
>> command, there are obvious memory leak found for glusterd process, when we
>> compare statedump of glusterd process before and after command executions.
>>
>>
>>
>> 1>   Each time of command “gluster volume list” command there are some
>> memory lost from section [mgmt/glusterd.management - usage-type
>> gf_common_mt_char memusage] in glusterd statedump, after investigation, we
>> found that
>>
>> For __glusterd_handle_cli_list_volume , after glusterd_submit_reply,
>> should free rsp.dict.dict_val.
>>
>  This needs to be looked at.

2>   Each time of command “gluster volume status <volume name>” command
>> there are some memory lost from section mgmt/glusterd.management -
>> usage-type gf_common_mt_strdup memusage in glusterd statedump, after
>> investigation, we found that
>>
>> For glusterd_mgmt_v3_unlock, before gf_timer_call_cancel, should free
>> pointer “data” in mgmt_lock_timer->timer.
>>
>
Gaurav is working on a patch where this has been already identified. So the
analysis on point 2 seems to be correct.


>
>>
>> Could you help to comment on the above two findings? Thanks!
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gluster.org/pipermail/gluster-devel/attachments/20180227/f452b860/attachment.html>