[Gluster-devel] tests/bugs/distribute/bug-1122443.t - spurious failure

[Raghavendra Gowdappa]

On Fri, Aug 3, 2018 at 5:03 PM, Raghavendra Gowdappa <rgowdapp at redhat.com>
wrote:

> Will take a look.
>

Patch https://review.gluster.org/16419 indeed had a bug. It used to zero
out stats just retaining ia_gfid and ia_type. However, fuse_readdirp_cbk
would pass the attributes as valid to kernel causing the bug. I've fixed
this issue in https://review.gluster.org/20639.


> On Fri, Aug 3, 2018 at 3:08 PM, Krutika Dhananjay <kdhananj at redhat.com>
> wrote:
>
>> Adding Raghavendra G who actually restored and reworked on this after it
>> was abandoned.
>>
>> -Krutika
>>
>> On Fri, Aug 3, 2018 at 2:38 PM, Nithya Balachandran <nbalacha at redhat.com>
>> wrote:
>>
>>> Using git bisect, the patch that introduced this behaviour is :
>>>
>>> commit 7131de81f72dda0ef685ed60d0887c6e14289b8c
>>> Author: Krutika Dhananjay <kdhananj at redhat.com>
>>> Date:   Tue Jan 17 16:40:04 2017 +0530
>>>
>>>     performance/readdir-ahead: Invalidate cached dentries if they're
>>> modified while in cache
>>>
>>> Krutika, can you take a look and fix this?
>>>
>>> To summarize, this is _not_ a spurious failure.
>>>
>>>
>>> regards,
>>> Nithya
>>>
>>>
>>> On 3 August 2018 at 14:13, Nithya Balachandran <nbalacha at redhat.com>
>>> wrote:
>>>
>>>> This is a new issue - the test uses ls -l to get some information. With
>>>> the latest master, ls -l returns strange results the first time it is
>>>> called on the mount point causing the test to fail:
>>>>
>>>>
>>>> With the latest master, I created a single brick volume and some files
>>>> inside it.
>>>>
>>>> [root at rhgs313-6 ~]# umount -f /mnt/fuse1; mount -t glusterfs -s
>>>> 192.168.122.6:/thunder /mnt/fuse1; ls -l /mnt/fuse1/; echo "Trying
>>>> again"; ls -l /mnt/fuse1
>>>> umount: /mnt/fuse1: not mounted
>>>> total 0
>>>> *----------. 0 root root 0 Jan  1  1970 file-1*
>>>> *----------. 0 root root 0 Jan  1  1970 file-2*
>>>> *----------. 0 root root 0 Jan  1  1970 file-3*
>>>> *----------. 0 root root 0 Jan  1  1970 file-4*
>>>> *----------. 0 root root 0 Jan  1  1970 file-5*
>>>> *d---------. 0 root root 0 Jan  1  1970 subdir*
>>>> Trying again
>>>> total 3
>>>> -rw-r--r--. 1 root root 33 Aug  3 14:06 file-1
>>>> -rw-r--r--. 1 root root 33 Aug  3 14:06 file-2
>>>> -rw-r--r--. 1 root root 33 Aug  3 14:06 file-3
>>>> -rw-r--r--. 1 root root 33 Aug  3 14:06 file-4
>>>> -rw-r--r--. 1 root root 33 Aug  3 14:06 file-5
>>>> d---------. 0 root root  0 Jan  1  1970 subdir
>>>> [root at rhgs313-6 ~]#
>>>>
>>>>
>>>>
>>>> This is consistently reproducible. I am still debugging this to see
>>>> which patch caused this.
>>>>
>>>> regards,
>>>> Nithya
>>>>
>>>>
>>>> On 2 August 2018 at 07:13, Atin Mukherjee <atin.mukherjee83 at gmail.com>
>>>> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Thu, 2 Aug 2018 at 07:05, Susant Palai <spalai at redhat.com> wrote:
>>>>>
>>>>>> Will have a look at it and update.
>>>>>>
>>>>>
>>>>> There’s already a patch from Mohit for this.
>>>>>
>>>>>
>>>>>> Susant
>>>>>>
>>>>>> On Wed, 1 Aug 2018, 18:58 Krutika Dhananjay, <kdhananj at redhat.com>
>>>>>> wrote:
>>>>>>
>>>>>>> Same here - https://build.gluster.org/job/
>>>>>>> centos7-regression/2024/console
>>>>>>>
>>>>>>> -Krutika
>>>>>>>
>>>>>>> On Sun, Jul 29, 2018 at 1:53 PM, Atin Mukherjee <amukherj at redhat.com
>>>>>>> > wrote:
>>>>>>>
>>>>>>>> tests/bugs/distribute/bug-1122443.t fails my set up (3 out of 5
>>>>>>>> times) running with master branch. As per my knowledge I've not seen this
>>>>>>>> test failing earlier. Looks like some recent changes has caused it. One of
>>>>>>>> such instance is https://build.gluster.org/job/
>>>>>>>> centos7-regression/1955/ .
>>>>>>>>
>>>>>>>> Request the component owners to take a look at it.
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> Gluster-devel mailing list
>>>>>>>> Gluster-devel at gluster.org
>>>>>>>> https://lists.gluster.org/mailman/listinfo/gluster-devel
>>>>>>>>
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Gluster-devel mailing list
>>>>>>> Gluster-devel at gluster.org
>>>>>>> https://lists.gluster.org/mailman/listinfo/gluster-devel
>>>>>>
>>>>>> _______________________________________________
>>>>>> Gluster-devel mailing list
>>>>>> Gluster-devel at gluster.org
>>>>>> https://lists.gluster.org/mailman/listinfo/gluster-devel
>>>>>
>>>>> --
>>>>> --Atin
>>>>>
>>>>> _______________________________________________
>>>>> Gluster-devel mailing list
>>>>> Gluster-devel at gluster.org
>>>>> https://lists.gluster.org/mailman/listinfo/gluster-devel
>>>>>
>>>>
>>>>
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gluster.org/pipermail/gluster-devel/attachments/20180805/2777f7e8/attachment.html>