[Gluster-devel] tests/basic/pump.t - what is it used for?

Amar Tumballi atumball at redhat.com
Fri Sep 8 06:44:04 UTC 2017


All I know is pump translator is written long back to support
'replace-brick' without data-loss in distributed setup too. But we figured
out pump is not maintainable along the way, and said you can't do a
replace-brick in distributed volume type.

https://github.com/gluster/glusterfs/commit/acdeed002d30209e0a058c2df0346d
4f16c08994

I don't see that its used now, so looks like we can remove this test.

-Amar

On Fri, Sep 8, 2017 at 10:02 AM, Atin Mukherjee <amukherj at redhat.com> wrote:

> Pranith,
>
> I see you're the author of the test in $Subj. Now while I was working on a
> patch https://review.gluster.org/#/c/18226/ to disallow replace brick
> operations on dist only volumes the patch failed the regression on this
> test as the test actually uses replace brick on a distribute only volume
> which IMO is wrong as then this would always end up in to data loss
> situation. I'd need some context here to understand the expectation of this
> test before doing any modifications.
>
> ~Atin
>
> _______________________________________________
> Gluster-devel mailing list
> Gluster-devel at gluster.org
> http://lists.gluster.org/mailman/listinfo/gluster-devel
>



-- 
Amar Tumballi (amarts)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gluster.org/pipermail/gluster-devel/attachments/20170908/d11a9556/attachment.html>


More information about the Gluster-devel mailing list