[Gluster-devel] reagarding backport information while porting patches

[Pranith Kumar Karampuri]

On Fri, Jun 23, 2017 at 9:37 AM, Ravishankar N <ravishankar at redhat.com>
wrote:

> On 06/23/2017 09:15 AM, Pranith Kumar Karampuri wrote:
>
> hi,
>      Now that we are doing backports with same Change-Id, we can find the
> patches and their backports both online and in the tree without any extra
> information in the commit message. So shall we stop adding text similar to:
>
>     > Reviewed-on: https://review.gluster.org/17414
>
>
> Sometimes I combine 2 commits from master (typically commit 2 which fixes
> a bug in commit 1) in to a single patch while backporting. The change ID is
> not the same in that case and I explicitly mention the 2 patch urls in the
> squashed commit sent to the release branch.  So in those cases, some way to
> trace back to the patches in master is helpful. Otherwise I think it is
> fair to omit it.
>

Ah! makes sense. Maybe for exceptions, let us use this but as a rule maybe
it doesn't seem like a bad idea to omit. Let us also hear from others.


>     > Smoke: Gluster Build System <jenkins at build.gluster.org>
>     > Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
>     > Tested-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
>     > NetBSD-regression: NetBSD Build System <jenkins at build.gluster.org>
>     > Reviewed-by: Amar Tumballi <amarts at redhat.com>
>     > CentOS-regression: Gluster Build System <jenkins at build.gluster.org>
>     (cherry picked from commit de92c363c95d16966dbcc9d8763fd4448dd84d13)
>
> in the patches?
>
> Do you see any other value from this information that I might be missing?
>
> --
> Pranith
>
>
> _______________________________________________
> Gluster-devel mailing listGluster-devel at gluster.orghttp://lists.gluster.org/mailman/listinfo/gluster-devel
>
>
>


-- 
Pranith
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.gluster.org/pipermail/gluster-devel/attachments/20170623/e62d7ccc/attachment.html>