[Gluster-devel] C99 requirement in Gluster ?

[Niels de Vos]

On Mon, Feb 20, 2017 at 06:33:24AM -0500, Kaleb Keithley wrote:
> 
> 
> ----- Original Message -----
> > From: "Michael Scherer" <mscherer at redhat.com>
> > 
> > so I was reading coverty scan reports (as Nigel tricked me into looking
> > them), and one of the first is this:
> > https://download.gluster.org/pub/gluster/glusterfs/static-analysis/master/glusterfs-coverity/2017-02-07-3c86d946/html/1/8rpc-transport.c.html#error
> > 
> > at first, i was wondering why/what is the issue.
> > 
> > But, after searching, int8_t is a C99 type, which is signed when
> > compiled on C99 compiler, and likely unsigned when compiled using a non
> > C99 compiler (as I see in ./contrib/argp-standalone/acinclude.m4 , it
> > will be defined to "char" on non c99 platform, which also make no
> > garantee on being signed or unsigned, according to
> > https://stackoverflow.com/questions/4337217/difference-between-signed-unsigned-char
> > ).
> > 
> > So, to fix that, should we force to use c99, or update argp-standalone ?
> 
> argp-standalone is contrib. Are there newer sources available somewhere?

Ideally this is not used anywhere anymore and the library provided by
the target distribution is linked instead. Maybe it is finally time to
remove contrib/argp-standalone ?

Niels
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.gluster.org/pipermail/gluster-devel/attachments/20170220/ab07e804/attachment.sig>