[Gluster-devel] Current master branch fails to build

[Niels de Vos]

On Mon, Aug 28, 2017 at 08:18:50PM +0000, jenkins at build.gluster.org wrote:
> See <https://build.gluster.org/job/regression-test-with-multiplex/294/display/redirect?page=changes>
> 
> Changes:
> 
> [Jeff Darcy] statedump: add support for dumping basic mem-pool info
> 
> [Jeff Darcy] mem-pool: add tracking of mem_pool that requested the allocation
> 
> [Jeff Darcy] cluster/ec: coverity, fix for BAD_SHIFT
> 
> ------------------------------------------
> Started by timer

... snip!

>   CC     libglusterfs_la-stack.lo
> <https://build.gluster.org/job/regression-test-with-multiplex/ws/libglusterfs/src/statedump.c>: In function ‘gf_proc_dump_mempool_info’:
> <https://build.gluster.org/job/regression-test-with-multiplex/ws/libglusterfs/src/statedump.c>:401: error: ‘glusterfs_ctx_t’ has no member named ‘mempool_list’
> <https://build.gluster.org/job/regression-test-with-multiplex/ws/libglusterfs/src/statedump.c>:401: error: ‘struct mem_pool’ has no member named ‘owner’
> <https://build.gluster.org/job/regression-test-with-multiplex/ws/libglusterfs/src/statedump.c>:401: error: ‘struct mem_pool’ has no member named ‘owner’
> <https://build.gluster.org/job/regression-test-with-multiplex/ws/libglusterfs/src/statedump.c>:401: error: ‘glusterfs_ctx_t’ has no member named ‘mempool_list’
> <https://build.gluster.org/job/regression-test-with-multiplex/ws/libglusterfs/src/statedump.c>:401: error: ‘struct mem_pool’ has no member named ‘owner’
> <https://build.gluster.org/job/regression-test-with-multiplex/ws/libglusterfs/src/statedump.c>:401: error: ‘struct mem_pool’ has no member named ‘owner’
> <https://build.gluster.org/job/regression-test-with-multiplex/ws/libglusterfs/src/statedump.c>:402: error: ‘struct mem_pool’ has no member named ‘active’
> make[3]: *** [libglusterfs_la-statedump.lo] Error 1

This is happening because the mem-pool changes that got merged depend on
https://review.gluster.org/18075 . A revised version to address review
comments is currently undergoing regression testing.

Please review and merge these two patches in the following order:

1. mem-pool: track glusterfs_ctx_t in struct mem_pool
   https://review.gluster.org/18075

2. mem-pool: count allocations done per user-pool
   https://review.gluster.org/18074

In case (1) needs more changes, feel free to modify the change. It is
the easiest to use git-review for that:

   $ git review -r origin -d 18075
   [ edit files ]
   $ git commit -a --fixup=HEAD
   [ test build ]
   $ git rebase -i --autosquash HEAD~2
   $ git review -r origin -R -t rfc master

Thanks!
Niels
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 801 bytes
Desc: not available
URL: <http://lists.gluster.org/pipermail/gluster-devel/attachments/20170829/26ec9672/attachment.sig>