[Gluster-devel] MKDIR_P and mkdir_p

[Milind Changire]

On Mon, May 09, 2016 at 12:02:56PM +0530, Milind Changire wrote:
 > Niels, Kaleb,
 > With Niels' commit 4ac2ff18db62db192c49affd8591e846c810667a
 > reverting Manu's commit 1fbcecb72ef3525823536b640d244d1e5127a37f
 > on upstream master, and w.r.t. Kaleb's patch
 > http://review.gluster.org/14243
 > with Niels' comment to move the lines to the Makefile, it looks
 > like the Makefile.am in tools/glusterfind/ is already coded to do
 > what Kaleb has proposed in the patch.
 >
 > If you look at the upstream SPEC file there's been an %install
 > entry added to create a %{_sharedstatedir/glusterd/glusterfind/.keys
 > directory. But looking at tools/glusterfind/Makefile.am, this looks
 > like an already solved problem. However, I think this came by due to
 > the MKDIR_P/mkdir_p not working on some platforms and hence leading to
 > the SPEC file kludges.
 >
 > How do we get out of this MKDIR_P vs mkdir_p issue once and for all
 > for all the platforms? This is especially painful during downstream
 > packaging.

Current upstream only seems to use mkdir_p in Makefile.am files:

     $ git grep MKDIR_P -- '*/Makefile.am'

     $ git grep mkdir_p -- '*/Makefile.am'
     cli/src/Makefile.am:    $(mkdir_p) 
$(DESTDIR)$(localstatedir)/run/gluster
     extras/Makefile.am:             $(mkdir_p) $(DESTDIR)$(tmpfilesdir); \
     extras/Makefile.am:     $(mkdir_p) $(DESTDIR)$(GLUSTERD_WORKDIR)/groups
     extras/init.d/Makefile.am:              $(mkdir_p) 
$(DESTDIR)$(INIT_DIR); \
     extras/init.d/Makefile.am:      $(mkdir_p) $(DESTDIR)$(LAUNCHD_DIR)
     extras/systemd/Makefile.am:             $(mkdir_p) 
$(DESTDIR)$(SYSTEMD_DIR); \
     tools/glusterfind/Makefile.am:  $(mkdir_p) 
$(DESTDIR)$(GLUSTERD_WORKDIR)/glusterfind/.keys
     tools/glusterfind/Makefile.am:  $(mkdir_p) 
$(DESTDIR)$(GLUSTERD_WORKDIR)/hooks/1/delete/post/
     xlators/mgmt/glusterd/src/Makefile.am:  $(mkdir_p) 
$(DESTDIR)$(GLUSTERD_WORKDIR)

This might, or mught not be correct. Because you found the commit where
Manu mentioned that mkdir_p is not available on all distributions, you
may want to get his opinion too? Just send the email to the devel list
and we can discuss it there.

-- 
Milind