[Gluster-devel] Bitrot Review Request

[Pranith Kumar Karampuri]

On Fri, Apr 29, 2016 at 12:37 PM, Kotresh Hiremath Ravishankar <
khiremat at redhat.com> wrote:

> Hi Pranith,
>
> You had a concern of consuming I/O threads when bit-rot uses rchecksum
> interface to
> signing, normal scrubbing and on-demand scrubbing with tiering.
>
>
> http://review.gluster.org/#/c/13833/5/xlators/storage/posix/src/posix.c
>
> As discussed over comments, the concern is valid and the above patch is
> not being
> taken in and would be abandoned.
>
> I have the following patch where the signing and normal scrubbing would not
> consume io-threads. Only the on-demand scrubbing consumes io-threads. I
> think
> this should be fine as tiering is single threaded and only consumes
> one I/O thread (as told by Joseph on PatchSet 6).
>
>       http://review.gluster.org/#/c/13969/


I have a feeling that even this will become multi-threaded just like
rebalance/self-heal have become. How do we future proof it?

Pranith


>
>
> Since, on-demand scrubbing is disabled by default and there is a size cap
> and
> we document to increase the default number of I/O threads, consuming one
> I/O
> thread for scrubbing would be fine I guess.
>
> Let me know your thoughts.
>
> Thanks and Regards,
> Kotresh H R
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.gluster.org/pipermail/gluster-devel/attachments/20160503/f696f909/attachment-0001.html>