[Gluster-devel] Question on merging zfs snapshot support into the mainline glusterfs

[Rajesh Joseph]

On Thu, Jul 21, 2016 at 3:07 AM, Vijay Bellur <vbellur at redhat.com> wrote:

> On 07/19/2016 11:01 AM, Atin Mukherjee wrote:
>
>>
>>
>> On Tue, Jul 19, 2016 at 7:29 PM, Rajesh Joseph <rjoseph at redhat.com
>> <mailto:rjoseph at redhat.com>> wrote:
>>
>>
>>
>>     On Tue, Jul 19, 2016 at 11:23 AM, <sriram at marirs.net.in
>>     <mailto:sriram at marirs.net.in>> wrote:
>>
>>         __
>>         Hi Rajesh,
>>
>>         I'd thought about moving the zfs specific implementation to
>>         something like
>>
>>         xlators/mgmt/glusterd/src/plugins/zfs-specifs-stuffs for the
>>         inital go. Could you let me know if this works or in sync with
>>         what you'd thought about?
>>
>>         Sriram
>>
>>
>>     Hi Sriram,
>>
>>     Sorry, I was not able to send much time on this. I would prefer you
>>     move the code to
>>
>>     xlators/mgmt/glusterd/plugins/src/zfs-specifs-stuffs
>>
>>
>>
>> How about having it under
>> xlators/mgmt/glusterd/plugins/snapshot/src/zfs-specifs-stuffs such that
>> in future if we have to write plugins for other features they can be
>> segregated?
>>
>>
> It would be nicer to avoid "specific-stuff" or similar from the naming. We
> can probably leave it at xlators/mgmt/glusterd/plugins/snapshot/src/zfs.
> The naming would be sufficient to indicate that code is specific to zfs
> snapshots.
>

I don't think the directory would be named "zfs-specific_stuffs, instead
zfs specific source file will come directly under
"xlators/mgmt/glusterd/plugins/snapshot/src/".
I think I should have been more clear, my bad.

-Rajesh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.gluster.org/pipermail/gluster-devel/attachments/20160722/0d3a4374/attachment.html>