[Gluster-devel] tier: breaking down the monolith processing function

Milind Changire mchangir at redhat.com
Thu Jul 21 07:35:45 UTC 2016


On 07/21/2016 03:03 AM, Vijay Bellur wrote:
> On 07/19/2016 07:54 AM, Milind Changire wrote:
>> I've attempted to break the tier_migrate_using_query_file() function
>> into relatively smaller functions. The important one is
>> tier_migrate_link().
>>
>
>
> Can tier_migrate_link() be broken down further? Having more than 80-100
> LOC in a function does normally look excessive to me.
>
> Thanks,
> Vijay
>

I've broken it [1] down some more ... please take a look.

1. http://review.gluster.org/14957

--
Milind


More information about the Gluster-devel mailing list