[Gluster-devel] Wrong usage of dict functions

Pranith Kumar Karampuri pkarampu at redhat.com
Wed Jan 6 09:44:26 UTC 2016


hi,
        It seems like two ways to create dictionary is causing problems. 
There are quite a few dict_new()/dict_destroy() or 
get_new_dict()/dict_unref() in the code base. So stopped exposing the 
functions without ref/unref i.e. get_new_dict()/dict_destroy() as part 
of http://review.gluster.org/13183

Files changed as part of the patch:
  api/src/glfs-mgmt.c                            |  2 +-
  api/src/glfs.c                                 |  2 +-
  cli/src/cli-cmd-parser.c                       | 42 
+++++++++++++++++++++---------------------
  cli/src/cli-cmd-system.c                       |  6 +++---
  cli/src/cli-cmd-volume.c                       |  2 +-
  cli/src/cli-rpc-ops.c                          |  4 ++--
  cli/src/cli.c                                  |  2 +-
  glusterfsd/src/glusterfsd.c                    |  2 +-
  libglusterfs/src/dict.h                        |  5 -----
  libglusterfs/src/graph.c                       |  2 +-
  libglusterfs/src/graph.y                       |  2 +-
  xlators/cluster/afr/src/afr-self-heal-common.c |  6 +++---
  xlators/cluster/afr/src/afr-self-heal-name.c   |  2 +-
  xlators/cluster/dht/src/dht-selfheal.c         | 15 +++++++--------
  xlators/cluster/dht/src/dht-shared.c           |  2 +-
  xlators/mgmt/glusterd/src/glusterd-geo-rep.c   |  4 ++--
  xlators/mgmt/glusterd/src/glusterd-op-sm.c     |  4 ++--
  xlators/mgmt/glusterd/src/glusterd-volgen.c    | 12 ++++++------
  xlators/mount/fuse/src/fuse-bridge.c           |  3 +--
  xlators/mount/fuse/src/fuse-bridge.h           |  2 --
  20 files changed, 56 insertions(+), 65 deletions(-)


Pranith


More information about the Gluster-devel mailing list