[Gluster-devel] mainline compilation fails

[Poornima Gurusiddaiah]

Hi, 

Regarding the enforcement of the dependencies while merging, i see that 
the dependent patches on any patch is mentioned in the "Related Changes" 
column [1]. It still doesn't enforce, in the cherry-pick way of
submitting changes, by default it ignores the lineage [2]. But there are
ways to enforce this. Will let the gluster infra maintainers to comment
on the same.

[1] https://gerrit-review.googlesource.com/Documentation/user-review-ui.html#related-changes
[2] https://gerrit-review.googlesource.com/Documentation/project-configuration.html#project_options

Regards,
Poornima
----- Original Message ----- 

> From: "Prasanna Kalever" <pkalever at redhat.com>
> To: "Atin Mukherjee" <atin.mukherjee83 at gmail.com>
> Cc: "Gluster Devel" <gluster-devel at gluster.org>
> Sent: Saturday, August 27, 2016 11:11:33 AM
> Subject: Re: [Gluster-devel] mainline compilation fails

> Oops!
> Didn't noticed these changes were part of parent/child patches, Just
> noticed "BUILD BROKEN" and went into action :)

> I'm not sure about it!

> If it takes time to decide on whether the other set of patches need to
> be taken or not, at-least my patch will fix the broken build (That
> much I can assure)

> Lets see if the regressions break after these patch goes in (mostly
> not, that I see from the code)

> Thanks,
> --
> Prasanna

> On Sat, Aug 27, 2016 at 8:34 PM, Atin Mukherjee
> <atin.mukherjee83 at gmail.com> wrote:
> >
> >
> > On Saturday 27 August 2016, Prasanna Kalever <pkalever at redhat.com> wrote:
> >>
> >> Here is the patch that should fix it
> >> http://review.gluster.org/#/c/15331/
> >
> >
> > Thanks! Well thats an easy way, but the question here is dont we need the
> > parent patch to be merged to ensure there is no other functionality broken.
> > Currently I see that the parent patch has a -1, in that case is it required
> > to revert 15225?
> >>
> >>
> >> Happy weekend!
> >>
> >> --
> >> Prasanna
> >>
> >>
> >> On Sat, Aug 27, 2016 at 7:49 PM, Atin Mukherjee <amukherj at redhat.com>
> >> wrote:
> >> > [1] has broken mainline compilation and I feel this could be because its
> >> > parent patch is not been merged otherwise smoke should have caught it.
> >> > Please resolve it at earliest.
> >> >
> >> > [1] http://review.gluster.org/#/c/15225/
> >> >
> >> >
> >> > --Atin
> >> >
> >> > _______________________________________________
> >> > Gluster-devel mailing list
> >> > Gluster-devel at gluster.org
> >> > http://www.gluster.org/mailman/listinfo/gluster-devel
> >> _______________________________________________
> >> Gluster-devel mailing list
> >> Gluster-devel at gluster.org
> >> http://www.gluster.org/mailman/listinfo/gluster-devel
> >
> >
> >
> > --
> > --Atin
> _______________________________________________
> Gluster-devel mailing list
> Gluster-devel at gluster.org
> http://www.gluster.org/mailman/listinfo/gluster-devel