[Gluster-devel] [release-3.6] FreeBSD and NetBSD compile errors in GlusterD

[Kaushal M]

On Fri, Nov 20, 2015 at 9:17 AM, Atin Mukherjee <amukherj at redhat.com> wrote:
> Niels,
>
> We have had some discussions on this in last couple of community
> meetings. The problem is that 3.6 doesn't have all the NetBSD backport
> fixes which causes these issues. There is a mail thread with Manu [1] on
> this. The conclusion was to *avoid* regression/smoke test results for
> NetBSD on 3.6 branch till all the fixes are backported which itself
> needs some volunteer(s).

I think we were only discussing regression tests there. Fixing that
issue required backports to the regression test framework itself,
which required a/some volunteer(s). We never discussed stopping smoke
runs on the BSDs.

I investigated this compilation failure before, but I wasn't able to
figure out why it happened. Looking at the code, it should just build
and there is no reason for it to fail. We have the same code in 3.7
and master, but they build. I don't know if I'll be able to find
anything by a second attempt.

>
> [1]
> http://www.gluster.org/pipermail/gluster-devel/2015-November/thread.html#47082
>
> Thanks,
> Atin
>
> On 11/19/2015 10:05 PM, Niels de Vos wrote:
>> There still seem to be compile errors on FreeBSD related to GlusterD:
>>
>>     --- glusterd_la-glusterd-handler.lo ---
>>     /usr/home/jenkins/root/workspace/freebsd-smoke/xlators/mgmt/glusterd/src/glusterd-handler.c:684:55: warning: implicit conversion from enumeration type 'enum glusterd_op_sm_event_type_' to different enumeration type 'glusterd_op_t' (aka 'enum glusterd_op_') [-Wenum-conversion]
>>             glusterd_op_t                   op          = GD_OP_EVENT_LOCK;
>>                                             ~~            ^~~~~~~~~~~~~~~~
>>     ...
>>     --- glusterd_la-glusterd-op-sm.lo ---
>>     /usr/home/jenkins/root/workspace/freebsd-smoke/xlators/mgmt/glusterd/src/glusterd-op-sm.c:3692:19: error: use of undeclared identifier 'GF_REPLACE_OP_START'
>>             if (op != GF_REPLACE_OP_START) {
>>                       ^
>>     1 error generated.
>>     *** [glusterd_la-glusterd-op-sm.lo] Error code 1
>>
>>
>> A very similar error is reported on NetBSD:
>>
>>     --- glusterd_la-glusterd-op-sm.lo ---
>>       CC       glusterd_la-glusterd-op-sm.lo
>>     /home/jenkins/root/workspace/netbsd6-smoke/xlators/mgmt/glusterd/src/glusterd-op-sm.c: In function 'glusterd_op_start_rb_timer':
>>     /home/jenkins/root/workspace/netbsd6-smoke/xlators/mgmt/glusterd/src/glusterd-op-sm.c:3692:19: error: 'GF_REPLACE_OP_START' undeclared (first use in this function)
>>     /home/jenkins/root/workspace/netbsd6-smoke/xlators/mgmt/glusterd/src/glusterd-op-sm.c:3692:19: note: each undeclared identifier is reported only once for each function it appears in
>>     /home/jenkins/root/workspace/netbsd6-smoke/xlators/mgmt/glusterd/src/glusterd-op-sm.c: In function 'glusterd_bricks_select_status_volume':
>>     /home/jenkins/root/workspace/netbsd6-smoke/xlators/mgmt/glusterd/src/glusterd-op-sm.c:5807:34: warning: unused variable 'snapd'
>>     *** [glusterd_la-glusterd-op-sm.lo] Error code 1
>>
>> These come from a recent backport sent to the release-3.6 branch. See
>> the console output on
>> https://build.gluster.org/job/freebsd-smoke/10826/console an
>> https://build.gluster.org/job/netbsd6-smoke/9916/console for more
>> details.
>>
>> This was reported quite a while back already too:
>>
>>   http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/11853
>>
>> Thanks,
>> Niels
>>