[Gluster-devel] FreeBSD and NetBSD builds failing on master

[Vijay Bellur]

On Monday 02 November 2015 03:41 PM, Niels de Vos wrote:
> On Mon, Nov 02, 2015 at 01:19:48PM +0530, Raghavendra Talur wrote:
>> Hi All,
>>
>> Recently merged patch "debug/io-stats: Add FOP sampling feature" [1] has a
>> hard coded path for log directory and I think *BSD machines have a
>> different path for /var/log.
>>
>> Can we have the patch reverted till this is fixed?
>>
>>
>> [1] http://review.gluster.org/#/c/12210/
>
> We really need to be careful not to merge patches that have not passed
> the NetBSD/FreeBSD smoke tests. The comments clearly state FAILURE, and
> the NetBSD regression test was not passed either yet.
>

mea culpa here. It was an oversight from me and I  will ensure that the 
*BSD votes are not overridden without adequate due diligence before a merge.


> http://review.gluster.org/12484 is the fix, it has passed all smoke
> tests. If there is a real urgency, we can merge that before the
> regression tests have passed.
>

I have merged this patch ignoring the spurious regression test failure.

Thanks,
Vijay