[Gluster-devel] Fwd: Bug#778790: glusterfs: FTBFS on new archs: #includes sysctl.h

[Niels de Vos]

On Mon, Mar 02, 2015 at 08:54:16AM +0100, Patrick Matthäi wrote:
> Hola,
> 
> especially to Niels :)
> I just get this about the 3.6.2 version.

Thanks, the patch has now been posted for review and inclusion in the
master branch (for 3.7):
    http://review.gluster.org/9963

Let us know if you need this backported to 3.6, and we'll get that done
for 3.6.4 (3.6.3 is in beta already and close to be released).

Niels

> 
> 
> -------- Weitergeleitete Nachricht --------
> Betreff: 	Bug#778790: glusterfs: FTBFS on new archs: #includes sysctl.h
> Weitersenden-Datum: 	Sat, 28 Feb 2015 00:18:01 +0000
> Weitersenden-Von: 	Adam Borowski <kilobyte at angband.pl>
> Weitersenden-An: 	debian-bugs-dist at lists.debian.org
> Weitersenden-CC: 	Patrick Matthäi <pmatthaei at debian.org>
> Datum: 	Sat, 28 Feb 2015 01:15:23 +0100
> Von: 	Adam Borowski <kilobyte at angband.pl>
> Antwort an: 	Adam Borowski <kilobyte at angband.pl>, 778790 at bugs.debian.org
> An: 	Patrick Matthäi <pmatthaei at debian.org>
> Kopie (CC): 	778790 at bugs.debian.org
> 
> 
> 
> On Fri, Feb 27, 2015 at 03:28:50PM +0100, Patrick Matthäi wrote:
> >Am 19.02.2015 um 23:00 schrieb Adam Borowski:
> >>The sysctl(2) syscall isn't used by glusterfs on Linux on runtime (it would
> >>spam syslog if called), so it's safe to remove its header.  The attached
> >>patch does this.
> >
> >are you also able to reproduce this with 3.6.2-1 from experimental?
> 
> Yes, although the patch I provided didn't apply.  Here's a new one, for the
> experimental version.  Besides making it fit in the new context, I also
> changed the condition to defined(CTL_KERN) to match the block where sysctl
> is actually used.  Per the comment, /* DARWIN and *BSD */, it's equivalent
> to the old version.
> 
> -- 
> // If you believe in so-called "intellectual property", please immediately
> // cease using counterfeit alphabets.  Instead, contact the nearest temple
> // of Amon, whose priests will provide you with scribal services for all
> // your writing needs, for Reasonable and Non-Discriminatory prices.
> 
> 
> 

> --- glusterfs-3.6.2/xlators/mount/fuse/src/fuse-helpers.c~	2015-01-21 13:10:24.000000000 +0100
> +++ glusterfs-3.6.2/xlators/mount/fuse/src/fuse-helpers.c	2015-02-28 00:51:14.653040406 +0100
> @@ -17,7 +17,7 @@
>  #include <sys/types.h>
>  #include <libutil.h>
>  #include <sys/user.h>
> -#else
> +#elif defined(CTL_KERN)
>  #include <sys/sysctl.h>
>  #endif
>  
> 

> _______________________________________________
> Gluster-devel mailing list
> Gluster-devel at gluster.org
> http://www.gluster.org/mailman/listinfo/gluster-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://www.gluster.org/pipermail/gluster-devel/attachments/20150322/5080c2f2/attachment.sig>