[Gluster-devel] NetBSD regression in quota-nfs.t

[Emmanuel Dreyfus]

On Wed, Mar 18, 2015 at 10:03:28AM +0000, Emmanuel Dreyfus wrote:
> Any idea anyone? Perhaps we could justgot err instead?
> 		if (uuid_is_null (local->loc.gfid))
> 			goto err;

Indeed, the test passes with this patch:

diff --git a/xlators/features/marker/src/marker-quota.c b/xlators/features/marker/src/marker-quota.c
index b8d7a77..4f8d057 100644
--- a/xlators/features/marker/src/marker-quota.c
+++ b/xlators/features/marker/src/marker-quota.c
@@ -1183,7 +1183,8 @@ mq_get_xattr (call_frame_t *frame, void *cookie, xlator_t *this,
         if (uuid_is_null (local->loc.gfid))
                 uuid_copy (local->loc.gfid, local->loc.inode->gfid);
 
-        GF_UUID_ASSERT (local->loc.gfid);
+        if (uuid_is_null (local->loc.gfid))
+                goto err;
 
         STACK_WIND (frame, mq_check_n_set_inode_xattr, FIRST_CHILD(this),
                     FIRST_CHILD(this)->fops->lookup, &local->loc, xattr_req);


-- 
Emmanuel Dreyfus
manu at netbsd.org