[Gluster-devel] read-only xlator: ro_open and O_APPEND

[Milind Changire]

The ro_open(...) handler checks for O_WRONLY and O_RDWR flags but not
the O_APPEND flag. However, the ro_writev(...) handler takes care of
returning an EROFS appropriately. I guess that's probably the reason
the O_APPEND issue wasn't addressed so far.

Is it imperative that there should be a check for O_APPEND in
ro_open(...) which might act as a fail-fast method rather than
deferring until a ro_writev(...) is triggered?

However, I haven't attempted creating a read-only file system and
checking whether a valid file descriptor is returned or not in a
O_APPEND mode.


Milind
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.gluster.org/pipermail/gluster-devel/attachments/20150311/d5ed45d8/attachment.html>