[Gluster-devel] /tests/bugs/quota/bug-1153964.t is consistently failing

Sachin Pandit spandit at redhat.com
Thu Jun 25 12:26:38 UTC 2015



----- Original Message -----
> From: "Sachin Pandit" <spandit at redhat.com>
> To: "Xavier Hernandez" <xhernandez at datalab.es>
> Cc: "Gluster Devel" <gluster-devel at gluster.org>, "Raghavendra G" <raghavendra at gluster.com>
> Sent: Thursday, June 25, 2015 5:50:01 PM
> Subject: Re: [Gluster-devel] /tests/bugs/quota/bug-1153964.t is consistently failing
> 
> Hi Xavier,
> 
> I did a git pull and I could see the commit
> "01e42f25ebdc44847e8b1dce02f7fd486b40dbc2"
> in my repository. This commit is the revert of the commit
> "8ab6608accb62d6320d1fc1fbe651fcafd376270"
> 
> ~ Sachin.
> 
> ----- Original Message -----
> > From: "Xavier Hernandez" <xhernandez at datalab.es>
> > To: "Vijaikumar M" <vmallika at redhat.com>, "Gluster Devel"
> > <gluster-devel at gluster.org>
> > Cc: "Raghavendra G" <raghavendra at gluster.com>
> > Sent: Thursday, June 25, 2015 5:41:14 PM
> > Subject: Re: [Gluster-devel] /tests/bugs/quota/bug-1153964.t is
> > consistently failing
> > 
> > It seems that the patch has not been correctly committed into master. I
> > see it as merged in gerrit, but doing a 'git pull' on master on a local
> > repository doesn't seem to include it.

And it looks like [1] was rebased on Jun 24 at "10:02 AM"
and the reverted patch [2] got merged on Jun 24 at "11:41 AM".
That is the reason why [1] is failing the same test case.

[1] http://review.gluster.org/#/c/10465/
[2] http://review.gluster.org/#/c/11362/

~ Sachin.

> > 
> > Am I doing something wrong ?
> > 
> > It also seems that a recently rebased patch is still failing because of
> > the same problem:
> > 
> > http://build.gluster.org/job/rackspace-regression-2GB-triggered/11258/consoleFull
> > 
> > Xavi
> > 
> > On 06/24/2015 08:21 AM, Vijaikumar M wrote:
> > > Hi All,
> > >
> > > I request you to re-base your patch which are failed regression with
> > > test-case bug-1153964.t
> > >
> > > Thanks,
> > > Vijay
> > >
> > >
> > > On Wednesday 24 June 2015 11:42 AM, Raghavendra Gowdappa wrote:
> > >> http://review.gluster.org/#/c/11362/ has been merged.
> > >>
> > >> ----- Original Message -----
> > >>> From: "Atin Mukherjee" <amukherj at redhat.com>
> > >>> To: "Raghavendra Gowdappa" <rgowdapp at redhat.com>
> > >>> Cc: "Niels de Vos" <ndevos at redhat.com>, "Vijaikumar M"
> > >>> <vmallika at redhat.com>, "Raghavendra G"
> > >>> <raghavendra at gluster.com>, "Gluster Devel" <gluster-devel at gluster.org>
> > >>> Sent: Wednesday, June 24, 2015 10:55:02 AM
> > >>> Subject: Re: [Gluster-devel] /tests/bugs/quota/bug-1153964.t is
> > >>> consistently failing
> > >>>
> > >>>
> > >>>
> > >>> On 06/24/2015 10:53 AM, Raghavendra Gowdappa wrote:
> > >>>>
> > >>>> ----- Original Message -----
> > >>>>> From: "Atin Mukherjee" <amukherj at redhat.com>
> > >>>>> To: "Niels de Vos" <ndevos at redhat.com>, "Vijaikumar M"
> > >>>>> <vmallika at redhat.com>
> > >>>>> Cc: "Raghavendra G" <raghavendra at gluster.com>, "Gluster Devel"
> > >>>>> <gluster-devel at gluster.org>
> > >>>>> Sent: Wednesday, June 24, 2015 10:15:12 AM
> > >>>>> Subject: Re: [Gluster-devel] /tests/bugs/quota/bug-1153964.t is
> > >>>>> consistently failing
> > >>>>>
> > >>>>> When is this patch getting merged, this is blocking other patches
> > >>>>> to get
> > >>>>> in.
> > >>>> Revert of http://review.gluster.org/11311, is waiting for regression
> > >>>> runs
> > >>>> to pass. There are three patches (duplicates of each other). If
> > >>>> anyone of
> > >>>> them pass both regression runs, I'll merge them. As far as refcounting
> > >>>> mechanism go, it'll take some time to review and merge the patch.
> > >>> Once the revert patch is merged, we are good to go. Please let us know
> > >>> once it's merged as post that all patches need rebase.
> > >>>
> > >>> ~Atin
> > >>>>> ~Atin
> > >>>>>
> > >>>>> On 06/23/2015 06:26 PM, Niels de Vos wrote:
> > >>>>>> On Tue, Jun 23, 2015 at 05:30:39PM +0530, Vijaikumar M wrote:
> > >>>>>>>
> > >>>>>>> On Tuesday 23 June 2015 04:28 PM, Niels de Vos wrote:
> > >>>>>>>> On Tue, Jun 23, 2015 at 03:45:43PM +0530, Vijaikumar M wrote:
> > >>>>>>>>> I have submitted below patch which fixes this issue. I am
> > >>>>>>>>> handling
> > >>>>>>>>> memory
> > >>>>>>>>> clean-up with reference countmechanism.
> > >>>>>>>>>
> > >>>>>>>>> http://review.gluster.org/#/c/11361
> > >>>>>>>> Is there a reason you can not use the (new) refcounting
> > >>>>>>>> functions that
> > >>>>>>>> were introduceed with http://review.gluster.org/11022 ?
> > >>>>>>> I was not aware that ref-counting patch was merged. Sure we will
> > >>>>>>> use
> > >>>>>>> these
> > >>>>>>> function and re-submit my patch.
> > >>>>>> Ok, thanks!
> > >>>>>> Niels
> > >>>>>>
> > >>>>>>> Thanks,
> > >>>>>>> Vijay
> > >>>>>>>
> > >>>>>>>
> > >>>>>>>> It would be nicer to standardize all refcounting mechanisms on one
> > >>>>>>>> implementation. I hope we can replace existing refcounting with
> > >>>>>>>> this
> > >>>>>>>> one
> > >>>>>>>> too. Introducing more refcounting ways is not going to be helpful.
> > >>>>>>>>
> > >>>>>>>> Thanks,
> > >>>>>>>> Niels
> > >>>>>>>>
> > >>>>>>>>> Thanks,
> > >>>>>>>>> Vijay
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>>
> > >>>>>>>>> On Tuesday 23 June 2015 12:58 PM, Raghavendra G wrote:
> > >>>>>>>>>> Multiple replies to same query. Pick one ;).
> > >>>>>>>>>>
> > >>>>>>>>>> On Tue, Jun 23, 2015 at 12:55 PM, Venky Shankar
> > >>>>>>>>>> <yknev.shankar at gmail.com
> > >>>>>>>>>> <mailto:yknev.shankar at gmail.com>> wrote:
> > >>>>>>>>>>
> > >>>>>>>>>>     OK. Two reverts of the same patch ;)
> > >>>>>>>>>>
> > >>>>>>>>>>     Pick one.
> > >>>>>>>>>>
> > >>>>>>>>>>     On Tue, Jun 23, 2015 at 12:51 PM, Raghavendra Gowdappa
> > >>>>>>>>>>     <rgowdapp at redhat.com <mailto:rgowdapp at redhat.com>> wrote:
> > >>>>>>>>>>     > Seems like its a memory corruption caused by:
> > >>>>>>>>>>     > http://review.gluster.org/11311
> > >>>>>>>>>>     >
> > >>>>>>>>>>     > I've reverted the patch at:
> > >>>>>>>>>>     > http://review.gluster.org/11360
> > >>>>>>>>>>     >
> > >>>>>>>>>>     > ----- Original Message -----
> > >>>>>>>>>>     >> From: "Xavier Hernandez" <xhernandez at datalab.es
> > >>>>>>>>>>     <mailto:xhernandez at datalab.es>>
> > >>>>>>>>>>     >> To: "Gluster Devel" <gluster-devel at gluster.org
> > >>>>>>>>>>     <mailto:gluster-devel at gluster.org>>
> > >>>>>>>>>>     >> Sent: Tuesday, June 23, 2015 12:44:47 PM
> > >>>>>>>>>>     >> Subject: [Gluster-devel]
> > >>>>>>>>>> /tests/bugs/quota/bug-1153964.t is
> > >>>>>>>>>>     consistently failing
> > >>>>>>>>>>     >>
> > >>>>>>>>>>     >> Hi,
> > >>>>>>>>>>     >>
> > >>>>>>>>>>     >> the quota test bug-1153964.t is failing consistently for
> > >>>>>>>>>>     >> a
> > >>>>>>>>>>     >> totally
> > >>>>>>>>>>     >> unrelated patch. Is this a known issue ?
> > >>>>>>>>>>     >>
> > >>>>>>>>>>     >>
> > >>>>>>>>>>
> > >>>>>>>>>> http://build.gluster.org/job/rackspace-regression-2GB-triggered/11142/consoleFull
> > >>>>>>>>>>
> > >>>>>>>>>>     >>
> > >>>>>>>>>>
> > >>>>>>>>>> http://build.gluster.org/job/rackspace-regression-2GB-triggered/11165/consoleFull
> > >>>>>>>>>>
> > >>>>>>>>>>     >>
> > >>>>>>>>>>
> > >>>>>>>>>> http://build.gluster.org/job/rackspace-regression-2GB-triggered/11172/consoleFull
> > >>>>>>>>>>
> > >>>>>>>>>>     >>
> > >>>>>>>>>>
> > >>>>>>>>>> http://build.gluster.org/job/rackspace-regression-2GB-triggered/11191/consoleFull
> > >>>>>>>>>>
> > >>>>>>>>>>     >>
> > >>>>>>>>>>     >> Xavi
> > >>>>>>>>>>     >> _______________________________________________
> > >>>>>>>>>>     >> Gluster-devel mailing list
> > >>>>>>>>>>     >> Gluster-devel at gluster.org
> > >>>>>>>>>> <mailto:Gluster-devel at gluster.org>
> > >>>>>>>>>>     >> http://www.gluster.org/mailman/listinfo/gluster-devel
> > >>>>>>>>>>     >>
> > >>>>>>>>>>     > _______________________________________________
> > >>>>>>>>>>     > Gluster-devel mailing list
> > >>>>>>>>>>     > Gluster-devel at gluster.org
> > >>>>>>>>>> <mailto:Gluster-devel at gluster.org>
> > >>>>>>>>>>     > http://www.gluster.org/mailman/listinfo/gluster-devel
> > >>>>>>>>>>     _______________________________________________
> > >>>>>>>>>>     Gluster-devel mailing list
> > >>>>>>>>>>     Gluster-devel at gluster.org <mailto:Gluster-devel at gluster.org>
> > >>>>>>>>>>     http://www.gluster.org/mailman/listinfo/gluster-devel
> > >>>>>>>>>>
> > >>>>>>>>>>
> > >>>>>>>>>>
> > >>>>>>>>>>
> > >>>>>>>>>> --
> > >>>>>>>>>> Raghavendra G
> > >>>>>>>>>>
> > >>>>>>>>>>
> > >>>>>>>>>> _______________________________________________
> > >>>>>>>>>> Gluster-devel mailing list
> > >>>>>>>>>> Gluster-devel at gluster.org
> > >>>>>>>>>> http://www.gluster.org/mailman/listinfo/gluster-devel
> > >>>>>>>>> _______________________________________________
> > >>>>>>>>> Gluster-devel mailing list
> > >>>>>>>>> Gluster-devel at gluster.org
> > >>>>>>>>> http://www.gluster.org/mailman/listinfo/gluster-devel
> > >>>>>> _______________________________________________
> > >>>>>> Gluster-devel mailing list
> > >>>>>> Gluster-devel at gluster.org
> > >>>>>> http://www.gluster.org/mailman/listinfo/gluster-devel
> > >>>>>>
> > >>>>> --
> > >>>>> ~Atin
> > >>>>> _______________________________________________
> > >>>>> Gluster-devel mailing list
> > >>>>> Gluster-devel at gluster.org
> > >>>>> http://www.gluster.org/mailman/listinfo/gluster-devel
> > >>>>>
> > >>> --
> > >>> ~Atin
> > >>>
> > >
> > > _______________________________________________
> > > Gluster-devel mailing list
> > > Gluster-devel at gluster.org
> > > http://www.gluster.org/mailman/listinfo/gluster-devel
> > _______________________________________________
> > Gluster-devel mailing list
> > Gluster-devel at gluster.org
> > http://www.gluster.org/mailman/listinfo/gluster-devel
> > 
> _______________________________________________
> Gluster-devel mailing list
> Gluster-devel at gluster.org
> http://www.gluster.org/mailman/listinfo/gluster-devel
> 


More information about the Gluster-devel mailing list