[Gluster-devel] Mark all the xlator fops 'static '

[Soumya Koduri]

Hi,

With the applications using and loading different libraries, the 
function symbols with the same name may get resolved incorrectly 
depending on the order in which those libraries get dynamically loaded.

Recently we have seen an issue with 'snapview-client' xlator lookup fop 
- 'svc_lookup' which matched with one of the routines provided by 
libntirpc, used by NFS-Ganesha. More details are in [1], [2].

Similar issue with respect to uuid* routines was already reported in [3].

To avoid such issues, it may be better and a cleaner way to mark all the 
xlator fops static, like in [4].

We have raised bug1248669 to track all the required changes. Request the 
component maintainers to take a look and change the respective xlator 
fop definitions.

Thanks,
Soumya

[1] - https://bugzilla.redhat.com/show_bug.cgi?id=1245636#c6
[2] - https://bugzilla.redhat.com/show_bug.cgi?id=1248669
[3] - http://article.gmane.org/gmane.comp.file-systems.gluster.devel/10074
[4] - http://review.gluster.org/#/c/11805