[Gluster-devel] Porting to OS X / clang code reviews

Dennis Schafroth dennis at schafroth.dk
Fri Feb 27 08:26:15 UTC 2015


Hi

I have a some code changes to fix warnings and potential portability issues related to bug-1155181 <http://review.gluster.org/#/q/status:open+project:glusterfs+branch:master+topic:bug-1155181,n,z>, but would also show up on other platforms if compiling with (newer) clang.

Could I get you to review these 
http://review.gluster.org/9520 <http://review.gluster.org/9520>
http://review.gluster.org/9545 <http://review.gluster.org/9545>
http://review.gluster.org/9549 <http://review.gluster.org/9549>

Especially 
http://review.gluster.org/#/c/9522/ <http://review.gluster.org/#/c/9522/>

since it highlights some logic that isn’t quite.. logical.

cheers, 
:-Dennis
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.gluster.org/pipermail/gluster-devel/attachments/20150227/c2e1d874/attachment.html>


More information about the Gluster-devel mailing list