[Gluster-devel] Bug#778790: glusterfs: FTBFS on new archs: #includes sysctl.h

[Justin Clift]

Looking at the attached patch file:

  --- glusterfs-3.5.2.orig/xlators/mount/fuse/src/fuse-helpers.c
  +++ glusterfs-3.5.2/xlators/mount/fuse/src/fuse-helpers.c
  @@ -14,7 +14,7 @@
   #include "fuse-bridge.h"
   #if defined(GF_SOLARIS_HOST_OS)
   #include <sys/procfs.h>
  -#else
  +#elif defined GF_BSD_HOST_OS || defined GF_DARWIN_HOST_OS
   #include <sys/sysctl.h>
   #endif

We'd need to update this for current master first wouldn't we, then
backport it to release-3.6 and release-3.5?

The header code in master for this file seems a bit different than
the above, so it's not a straight apply.  Kind of suspecting the
patch may be incorrect, as in master the current code seems to
specifically exclude sys/sysctl.h from being included in FreeBSD.

Anyone have ideas?

+ Justin


On 23 Feb 2015, at 08:10, Patrick Matthäi <pmatthaei at debian.org> wrote:
> Hi,
> 
> please see below.
> 
> 
> -------- Weitergeleitete Nachricht --------
> Betreff:	Bug#778790: glusterfs: FTBFS on new archs: #includes sysctl.h
> Weitersenden-Datum:	Thu, 19 Feb 2015 22:03:02 +0000
> Weitersenden-Von:	Adam Borowski <kilobyte at angband.pl>
> Weitersenden-An:	debian-bugs-dist at lists.debian.org
> Weitersenden-CC:	Patrick Matthäi <pmatthaei at debian.org>
> Datum:	Thu, 19 Feb 2015 23:00:05 +0100
> Von:	Adam Borowski <kilobyte at angband.pl>
> Antwort an:	Adam Borowski <kilobyte at angband.pl>, 778790 at bugs.debian.org
> An:	Debian Bug Tracking System <submit at bugs.debian.org>
> 
> Package: glusterfs
> Version: 3.5.2-1
> Severity: wishlist
> Tags: patch
> User: 
> debian-x32 at lists.debian.org
> 
> Usertags: port-x32 ftbfs-x32
> 
> Hi!
> I'm afraid that glusterfs fails to build on new architectures.  This is
> caused by deprecated #include <sysctl.h>, which compiles successfully on
> old architectures, but on new archs like x32, contains nothing but a #error
> with an explanatory message.
> 
> The sysctl(2) syscall isn't used by glusterfs on Linux on runtime (it would
> spam syslog if called), so it's safe to remove its header.  The attached
> patch does this.
> 
> 
> -- System Information:
> Debian Release: 8.0
>   APT prefers unstable
>   APT policy: (600, 'unstable'), (500, 'unreleased'), (50, 'experimental')
> Architecture: x32 (x86_64)
> 
> Kernel: Linux 3.19.0-x32 (SMP w/6 CPU cores)
> Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
> Shell: /bin/sh linked to /bin/dash
> Init: sysvinit (via /sbin/init)
> 
> 
> 
> 
> <no-sysctl-on-linux.patch>_______________________________________________
> Gluster-devel mailing list
> Gluster-devel at gluster.org
> http://www.gluster.org/mailman/listinfo/gluster-devel

--
GlusterFS - http://www.gluster.org

An open source, distributed file system scaling to several
petabytes, and handling thousands of clients.

My personal twitter: twitter.com/realjustinclift