[Gluster-devel] [release-3.6] compile error: 'GF_REPLACE_OP_START' undeclared

Tue Aug 18 07:09:24 UTC 2015

+ Adding Raghavendra Bhat.

When is the next GA planned on this branch? And can we take patches in 
this branch while this is being investigated.

Regards,
Avra

On 08/18/2015 12:07 PM, Avra Sengupta wrote:
> Still hitting this on freebsd and netbsd smoke runs on release 3.6 
> branch. Are we merging patches on release 3.6 branch for now even with 
> these failures. I have two such patches that need to be merged.
>
> Regards,
> Avra
>
> On 07/06/2015 02:32 PM, Niels de Vos wrote:
>> On Mon, Jul 06, 2015 at 02:19:07PM +0530, Raghavendra Bhat wrote:
>>> On 07/06/2015 01:39 PM, Niels de Vos wrote:
>>>> On Mon, Jul 06, 2015 at 12:09:28PM +0530, Raghavendra Bhat wrote:
>>>>> On 07/06/2015 09:52 AM, Kaushal M wrote:
>>>>>> I checked on NetBSD-7.0_BETA and FreeBSD-10.1. I couldn't reproduce
>>>>>> this. I'll try on NetBSD-6 next.
>>>>>>
>>>>>> ~kaushal
>>>>> I think it has to be included before 3.6.4 is made G.A. I can wait 
>>>>> till the
>>>>> fix for this issue is merged before making 3.6.4. Does it sound 
>>>>> ok? Or
>>>>> should I go ahead with 3.6.4 and make a quick 3.6.5 with this fix?
>>>> I only care about getting http://review.gluster.org/11335 merged :-)
>>>>
>>>> This is a patch I promised to take into release-3.5. It would be nicer
>>>> to have this change included in the release-3.6 branch before I merge
>>>> the 3.5 backport. At the moment, 3.5.5 is waiting on this patch. But I
>>>> do not think you really need to delay 3.6.4 off for that one. It 
>>>> should
>>>> be fine if it lands in 3.6.5. (The compile error looks more like a 
>>>> 3.6.4
>>>> blocker.)
>>>>
>>>> Niels
>>> Niels,
>>>
>>> The patch you mentioned has received the acks and also has passed 
>>> the linux
>>> regression tests. But it seem to have failed netbsd regression tests.
>> Yes, at least the smoke tests on NetBSD and FreeBSD fail with the
>> compile error mentioned in the subject of this email :)
>>
>> Thanks,
>> Niels
>>
>>
>>> Regards,
>>> Raghavendra Bhat
>>>
>>>>> Regards,
>>>>> Raghavendra Bhat
>>>>>
>>>>>> On Mon, Jul 6, 2015 at 8:38 AM, Kaushal M <kshlmster at gmail.com> 
>>>>>> wrote:
>>>>>>> Krutika hit this last week, and let us (GlusterD maintiners) 
>>>>>>> know of
>>>>>>> it. I volunteered to look into this, but couldn't find time. 
>>>>>>> I'll do
>>>>>>> it now.
>>>>>>>
>>>>>>> ~kaushal
>>>>>>>
>>>>>>> On Sun, Jul 5, 2015 at 10:43 PM, Atin Mukherjee
>>>>>>> <atin.mukherjee83 at gmail.com> wrote:
>>>>>>>> I remember Krutika reporting it few days back. So it seems like 
>>>>>>>> its not
>>>>>>>> fixed yet. If there is no taker I will send a patch tomorrow.
>>>>>>>>
>>>>>>>> -Atin
>>>>>>>> Sent from one plus one
>>>>>>>>
>>>>>>>> On Jul 5, 2015 9:58 PM, "Niels de Vos" <ndevos at redhat.com> wrote:
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> it seems that the current release-3.6 branch does not compile on
>>>>>>>>> FreedBSD and NetBSD (not sure why it compiles on CentOS-6). 
>>>>>>>>> These errors
>>>>>>>>> are thrown:
>>>>>>>>>
>>>>>>>>>    --- glusterd_la-glusterd-op-sm.lo ---
>>>>>>>>>      CC       glusterd_la-glusterd-op-sm.lo
>>>>>>>>>
>>>>>>>>> /home/jenkins/root/workspace/netbsd6-smoke/xlators/mgmt/glusterd/src/glusterd-op-sm.c: 
>>>>>>>>>
>>>>>>>>> In function 'glusterd_op_start_rb_timer':
>>>>>>>>>
>>>>>>>>> /home/jenkins/root/workspace/netbsd6-smoke/xlators/mgmt/glusterd/src/glusterd-op-sm.c:3685:19: 
>>>>>>>>>
>>>>>>>>> error: 'GF_REPLACE_OP_START' undeclared (first use in this 
>>>>>>>>> function)
>>>>>>>>>
>>>>>>>>> /home/jenkins/root/workspace/netbsd6-smoke/xlators/mgmt/glusterd/src/glusterd-op-sm.c:3685:19: 
>>>>>>>>>
>>>>>>>>> note: each undeclared identifier is reported only once for 
>>>>>>>>> each function it
>>>>>>>>> appears in
>>>>>>>>>
>>>>>>>>> /home/jenkins/root/workspace/netbsd6-smoke/xlators/mgmt/glusterd/src/glusterd-op-sm.c: 
>>>>>>>>>
>>>>>>>>> In function 'glusterd_bricks_select_status_volume':
>>>>>>>>>
>>>>>>>>> /home/jenkins/root/workspace/netbsd6-smoke/xlators/mgmt/glusterd/src/glusterd-op-sm.c:5800:34: 
>>>>>>>>>
>>>>>>>>> warning: unused variable 'snapd'
>>>>>>>>>    *** [glusterd_la-glusterd-op-sm.lo] Error code 1
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Could someone send a (pointer to the) backport that addresses 
>>>>>>>>> this?
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Niels
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Sun, Jul 05, 2015 at 08:59:32AM -0700, Gluster Build System 
>>>>>>>>> (Code
>>>>>>>>> Review) wrote:
>>>>>>>>>> Gluster Build System has posted comments on this change.
>>>>>>>>>>
>>>>>>>>>> Change subject: nfs: make it possible to disable nfs.mount-rmtab
>>>>>>>>>> ...................................................................... 
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Patch Set 1: -Verified
>>>>>>>>>>
>>>>>>>>>> Build Failed
>>>>>>>>>>
>>>>>>>>>> http://build.gluster.org/job/compare-bug-version-and-git-branch/9953/ 
>>>>>>>>>> :
>>>>>>>>>> SUCCESS
>>>>>>>>>>
>>>>>>>>>> http://build.gluster.org/job/freebsd-smoke/8551/ : FAILURE
>>>>>>>>>>
>>>>>>>>>> http://build.gluster.org/job/smoke/19820/ : SUCCESS
>>>>>>>>>>
>>>>>>>>>> http://build.gluster.org/job/netbsd6-smoke/7808/ : FAILURE
>>>>>>>>>>
>>>>>>>>>> -- 
>>>>>>>>>> To view, visit http://review.gluster.org/11335
>>>>>>>>>> To unsubscribe, visit http://review.gluster.org/settings
>>>>>>>>>>
>>>>>>>>>> Gerrit-MessageType: comment
>>>>>>>>>> Gerrit-Change-Id: I40c4d8d754932f86fb2b1b2588843390464c773d
>>>>>>>>>> Gerrit-PatchSet: 1
>>>>>>>>>> Gerrit-Project: glusterfs
>>>>>>>>>> Gerrit-Branch: release-3.6
>>>>>>>>>> Gerrit-Owner: Niels de Vos <ndevos at redhat.com>
>>>>>>>>>> Gerrit-Reviewer: Gluster Build System 
>>>>>>>>>> <jenkins at build.gluster.com>
>>>>>>>>>> Gerrit-Reviewer: Kaleb KEITHLEY <kkeithle at redhat.com>
>>>>>>>>>> Gerrit-Reviewer: NetBSD Build System <jenkins at build.gluster.org>
>>>>>>>>>> Gerrit-Reviewer: Niels de Vos <ndevos at redhat.com>
>>>>>>>>>> Gerrit-Reviewer: Raghavendra Bhat <rabhat at redhat.com>
>>>>>>>>>> Gerrit-Reviewer: jiffin tony Thottan <jthottan at redhat.com>
>>>>>>>>>> Gerrit-HasComments: No
>>>>>>>>> _______________________________________________
>>>>>>>>> Gluster-devel mailing list
>>>>>>>>> Gluster-devel at gluster.org
>>>>>>>>> http://www.gluster.org/mailman/listinfo/gluster-devel
>>>>>>>> _______________________________________________
>>>>>>>> Gluster-devel mailing list
>>>>>>>> Gluster-devel at gluster.org
>>>>>>>> http://www.gluster.org/mailman/listinfo/gluster-devel
>>>>>>>>
>>>>>> _______________________________________________
>>>>>> Gluster-devel mailing list
>>>>>> Gluster-devel at gluster.org
>>>>>> http://www.gluster.org/mailman/listinfo/gluster-devel
>> _______________________________________________
>> Gluster-devel mailing list
>> Gluster-devel at gluster.org
>> http://www.gluster.org/mailman/listinfo/gluster-devel
>