[Gluster-devel] This looks like an interesting Gerrit option we could turn on

Jeff Darcy jdarcy at redhat.com
Wed Apr 29 06:40:54 UTC 2015


> > label.Label-Name.copyAllScoresOnTrivialRebase
> > 
> > If true, all scores for the label are copied forward when a new patch
> > set is uploaded that is a trivial rebase. A new patch set is considered
> > as trivial rebase if the commit message is the same as in the previous
> > patch set and if it has the same code delta as the previous patch set.
> > This is the case if the change was rebased onto a different parent. This
> > can be used to enable sticky approvals, reducing turn-around for trivial
> > rebases prior to submitting a change. Defaults to false.

"Same code delta" is a bit slippery.  It can't be determined from the
patch itself, because at least line numbers and diff context will have
changed and would need to be ignored to say something's the same.  I
think forwarding scores is valuable enough that I'm in favor of turning
this option on, but we should maintain awareness that scores might get
forwarded in some cases where perhaps they shouldn't.


More information about the Gluster-devel mailing list