[Gluster-devel] truncating grouplist

[Emmanuel Dreyfus]

Hi

I have a lot of log messages about this:
[2014-09-07 04:07:41.323747] W [rpc-clnt.c:1340:rpc_clnt_record]
0-gfs352-client-3: truncating grouplist from 500 to 87

This is produced here:

        /* The number of groups and the size of lk_owner depend on oneother.
         * We can truncate the groups, but should not touch the lk_owner. */
        max_groups = GF_AUTH_GLUSTERFS_MAX_GROUPS (au.lk_owner.lk_owner_len);
        if (au.groups.groups_len > max_groups) {
                GF_LOG_OCCASIONALLY (gf_auth_max_groups_log, clnt->conn.name,
                                     GF_LOG_WARNING, "truncating grouplist "
                                     "from %d to %d", au.groups.groups_len,
                                     max_groups);

                au.groups.groups_len = max_groups;
        }

Wound't it make sense to only log is max_groups < NGROUPS_MAX ? I do not
really care a group list is truncated if my system cannot handle the missing
groups anyway.

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu at netbsd.org