[Gluster-devel] basic/afr/gfid-self-heal.t on release-3.6/NetBSD

Harshavardhana harsha at harshavardhana.net
Sat Sep 6 05:08:04 UTC 2014


On Fri, Sep 5, 2014 at 9:53 PM, Emmanuel Dreyfus <manu at netbsd.org> wrote:
> Hi
>
> NetBSD passes basic/afr/gfid-self-heal.t on master but fails it on release-3.6.
> I do not recall fixing anything about it, hence I wonder if someone else has an
> idea of a fix that went into master and that could be related.
>
> It happens in test 33-34, here is the relevant tests, with comment added by me:
>
> #Check gfid self-heal doesn't happen from one brick to other when type mismatch
> #is present for a name, without any xattrs
> TEST kill_brick $V0 $H0 $B0/${V0}0
> TEST touch $M0/b
> TEST mkdir $B0/${V0}0/b
> TEST setfattr -x trusted.afr.$V0-client-0 $B0/${V0}1
> $CLI volume start $V0 force
> EXPECT_WITHIN $PROCESS_UP_TIMEOUT "1" afr_child_up_status $V0 0
>
> # 33: master/NetBSD: gets EIO, release-3.6/NetBSD: b is here and fine
> TEST ! stat $M0/b
>
> # 34: master/NetBSD: nothing, release-3.6/NetBSD: a gfid is returned
> gfid_0=$(gf_get_gfid_xattr $B0/${V0}0/b)
> TEST "[[ -z \"$gfid_0\" ]]"
>

commit 6c4325ca57bca72d10e5172f8423262cdb3a379c
Author: Krutika Dhananjay <kdhananj at redhat.com>
Date:   Thu Aug 21 17:27:17 2014 +0530

    cluster/afr: Propagate EIO on inode's type mismatch

    Original author of the test script:
                Pranith Kumar K <pkarampu at redhat.com>

    Change-Id: If515ecefd3c17f85f175b6a8cb4b78ce8c916de2
    BUG: 1132469
    Signed-off-by: Krutika Dhananjay <kdhananj at redhat.com>
    Reviewed-on: http://review.gluster.org/8574
    Tested-by: Gluster Build System <jenkins at build.gluster.com>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu at redhat.com>
    Tested-by: Pranith Kumar Karampuri <pkarampu at redhat.com>


This is the change, you need this patch. Since it isn't committed to
release-3.6 - you shouldn't be using
master regression tests on release-3.6

-- 
Religious confuse piety with mere ritual, the virtuous confuse
regulation with outcomes


More information about the Gluster-devel mailing list