[Gluster-devel] Invalid DIR * usage in quota xlator

Emmanuel Dreyfus manu at netbsd.org
Wed Oct 15 17:42:25 UTC 2014


J. Bruce Fields <bfields at fieldses.org> wrote:

> You're assuming no filesystem uses -1 as a cookie?
> Might be true, but it's taking a small chance.

Latest version does not work like this anymore: when EOF is reached,
current offset is recorded in pfd->dir_eof, and we fire EINVAL if
seekdir() failed to set the offset and the offset is not  pfd->dir_eof:

                if (telldir(dir) != (long)off && off != pfd->dir_eof)

-- 
Emmanuel Dreyfus
http://hcpnet.free.fr/pubz
manu at netbsd.org


More information about the Gluster-devel mailing list