[Gluster-devel] Invalid DIR * usage in quota xlator

[Pranith Kumar Karampuri]

On 10/13/2014 01:14 PM, Emmanuel Dreyfus wrote:
> On Mon, Oct 13, 2014 at 12:39:33PM +0530, Pranith Kumar Karampuri wrote:
>> Op_errno is valid only if 'op_ret < 0'. so that doesn't say much. After the
>> last readdir call with op_ret > 0, there will be one more readdir call for
>> which op_ret will come as '0'. That means reading of the directory is
>> complete.
> Right, I have 3 calls for end of directory:
> op_ret > 0, op_errno = ENOENT,  but glusterfs does an extra call and gets:
> op_ret = -1, op_errno = EINVAL, but NetBSD FUSE does an extra call ang gets:
> op_ret = -1, op_errno = EINVAL
>
> No bug here, just suboptimal behavior, both in glusterfs and NetBSD FUSE.
oh!, but shouldn't it get op_ret = 0 instead of op_ret -1, op_errno EINVAL?

Pranith
>