[Gluster-devel] client3_3_writev_cbk - rsp

Vijay Bellur vbellur at redhat.com
Sun Nov 16 07:38:34 UTC 2014


On 11/16/2014 04:17 AM, Rudra Siva wrote:
> same goes for fsync.
>
> On Sat, Nov 15, 2014 at 5:36 PM, Rudra Siva <rudrasiva11 at gmail.com> wrote:
>> Hi,
>>
>> In adding a new FOP and using writev as a reference, this may not be correct -
>>
>> https://github.com/gluster/glusterfs/blob/master/xlators/protocol/client/src/client-rpc-fops.c
>>
>> ret = xdr_to_generic (*iov, &rsp, (xdrproc_t)xdr_gfs3_truncate_rsp);
>>
>> should probably be:
>>
>> ret = xdr_to_generic (*iov, &rsp, (xdrproc_t)xdr_gfs3_write_rsp);
>>
>> Presently the routines seem to be the same but if they diverge this
>> can be a problem.
>>

Thanks for figuring this out. Would it be possible for you to send a 
patch to address this?

Regards,
Vijay



More information about the Gluster-devel mailing list